Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 226503002: Move modal dialogs from WebViewClient to WebFrameClient, part 1/3. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: clean Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.h
diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h
index 18e9ceab00afb145dbe61cffbc2599caa8b42dca..ecc6a9217c26747cdf09bc56f824ff814ee150bd 100644
--- a/content/browser/web_contents/web_contents_impl.h
+++ b/content/browser/web_contents/web_contents_impl.h
@@ -313,6 +313,17 @@ class CONTENT_EXPORT WebContentsImpl
virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE;
virtual void ShowContextMenu(RenderFrameHost* render_frame_host,
const ContextMenuParams& params) OVERRIDE;
+ virtual void RunJavaScriptMessage(RenderFrameHost* rfh,
+ const base::string16& message,
+ const base::string16& default_prompt,
+ const GURL& frame_url,
+ JavaScriptMessageType type,
+ IPC::Message* reply_msg,
+ bool* did_suppress_message) OVERRIDE;
+ virtual void RunBeforeUnloadConfirm(RenderFrameHost* rfh,
+ const base::string16& message,
+ bool is_reload,
+ IPC::Message* reply_msg) OVERRIDE;
virtual WebContents* GetAsWebContents() OVERRIDE;
// RenderViewHostDelegate ----------------------------------------------------
@@ -354,17 +365,18 @@ class CONTENT_EXPORT WebContentsImpl
virtual void RouteMessageEvent(
RenderViewHost* rvh,
const ViewMsg_PostMessage_Params& params) OVERRIDE;
- virtual void RunJavaScriptMessage(RenderViewHost* rvh,
- const base::string16& message,
- const base::string16& default_prompt,
- const GURL& frame_url,
- JavaScriptMessageType type,
- IPC::Message* reply_msg,
- bool* did_suppress_message) OVERRIDE;
- virtual void RunBeforeUnloadConfirm(RenderViewHost* rvh,
- const base::string16& message,
- bool is_reload,
- IPC::Message* reply_msg) OVERRIDE;
+ virtual void RunJavaScriptMessageOBSOLETE(
+ RenderViewHost* rvh,
+ const base::string16& message,
+ const base::string16& default_prompt,
+ const GURL& frame_url,
+ JavaScriptMessageType type,
+ IPC::Message* reply_msg,
+ bool* did_suppress_message) OVERRIDE;
+ virtual void RunBeforeUnloadConfirmOBSOLETE(RenderViewHost* rvh,
+ const base::string16& message,
+ bool is_reload,
+ IPC::Message* reply_msg) OVERRIDE;
virtual bool AddMessageToConsole(int32 level,
const base::string16& message,
int32 line_no,
@@ -646,7 +658,13 @@ class CONTENT_EXPORT WebContentsImpl
void RemoveDestructionObserver(WebContentsImpl* web_contents);
// Callback function when showing JS dialogs.
- void OnDialogClosed(RenderViewHost* rvh,
+ void OnDialogClosedOBSOLETE(RenderViewHost* rvh,
+ IPC::Message* reply_msg,
+ bool success,
+ const base::string16& user_input);
+
+ // Callback function when showing JS dialogs.
+ void OnDialogClosed(RenderFrameHost* rfh,
IPC::Message* reply_msg,
bool success,
const base::string16& user_input);

Powered by Google App Engine
This is Rietveld 408576698