Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2265003003:
Profile Avatar Selector: Fixes profile avatar border in the selected state. (Closed)
|
Created:
4 years, 4 months ago by Moe Modified:
4 years, 4 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionProfile Avatar Selector: Fixes profile avatar border in the selected state.
BUG=638101
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/dd547cb8220a0a77c3465f57d693582fe097bb82
Cr-Commit-Position: refs/heads/master@{#413528}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
Description was changed from ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. ========== to ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
mahmadi@chromium.org changed reviewers: + dbeam@chromium.org
Hi Dan, Please take a look. This broke by the fix for the blurry avatars. https://codereview.chromium.org/2241563003/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
On 2016/08/22 20:02:02, Dan Beam wrote: > lgtm Thank you.
The CQ bit was checked by mahmadi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/dd547cb8220a0a77c3465f57d693582fe097bb82 Cr-Commit-Position: refs/heads/master@{#413528} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dd547cb8220a0a77c3465f57d693582fe097bb82 Cr-Commit-Position: refs/heads/master@{#413528}
Message was sent while issue was closed.
Description was changed from ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/dd547cb8220a0a77c3465f57d693582fe097bb82 Cr-Commit-Position: refs/heads/master@{#413528} ========== to ========== Profile Avatar Selector: Fixes profile avatar border in the selected state. BUG=638101 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/dd547cb8220a0a77c3465f57d693582fe097bb82 Cr-Commit-Position: refs/heads/master@{#413528} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
