Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2264993002: Use base::SizeTToString instead of std::to_string (Closed)

Created:
4 years, 4 months ago by landell
Modified:
4 years, 2 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, eroman, mmenke, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::SizeTToString instead of std::to_string std::to_string is disallowed by the chromium code style and we get into trouble with a custom mips toolchain that lacks support. BUG= Committed: https://crrev.com/d11df65d06817de4f1559861d7b545b942684344 Cr-Commit-Position: refs/heads/master@{#413513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M net/log/bounded_file_net_log_observer.cc View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
landell
@reviewers: PTAL
4 years, 4 months ago (2016-08-22 09:24:41 UTC) #3
eroman
lgtm
4 years, 4 months ago (2016-08-22 16:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264993002/1
4 years, 4 months ago (2016-08-22 18:07:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 19:44:57 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d11df65d06817de4f1559861d7b545b942684344 Cr-Commit-Position: refs/heads/master@{#413513}
4 years, 4 months ago (2016-08-22 19:48:18 UTC) #11
landell
Thanks
4 years, 4 months ago (2016-08-23 07:08:13 UTC) #12
landell
Pushed a totally unrelated follow up to the wrong review. Please ignore.
4 years, 2 months ago (2016-10-04 10:36:33 UTC) #13
eroman
For the record, I went ahead and deleted the patchset #2.
4 years, 2 months ago (2016-10-04 19:39:32 UTC) #15
landell
4 years, 2 months ago (2016-10-06 06:52:12 UTC) #16
Message was sent while issue was closed.
On 2016/10/04 19:39:32, eroman wrote:
> For the record, I went ahead and deleted the patchset #2.

I didn't figure out how to do that. Thanks.

Powered by Google App Engine
This is Rietveld 408576698