chrome/browser/ui/webui/md_history_ui.cc - Issue 2264983002: MD History: Lazily load element files which are not needed for first paint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/md_history_ui.cc

Issue 2264983002: MD History: Lazily load element files which are not needed for first paint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Minor tweaks and rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/vulcanize.py ('K') | « chrome/browser/resources/vulcanize.py ('k') | chrome/test/data/webui/md_history/history_grouped_list_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/md_history_ui.cc

diff --git a/chrome/browser/ui/webui/md_history_ui.cc b/chrome/browser/ui/webui/md_history_ui.cc

index 2b1d688ae963a987b5ce7a1c9f6cbf1026a14ae8..587afbbe3d36a51b1e45c2fa856e68597a58c100 100644

--- a/chrome/browser/ui/webui/md_history_ui.cc

+++ b/chrome/browser/ui/webui/md_history_ui.cc

@@ -134,6 +134,10 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {

IDR_MD_HISTORY_APP_VULCANIZED_HTML);

source->AddResourcePath("app.crisper.js",

IDR_MD_HISTORY_APP_CRISPER_JS);

+ source->AddResourcePath("lazy_load.html",

+ IDR_MD_HISTORY_LAZY_LOAD_VULCANIZED_HTML);

+ source->AddResourcePath("lazy_load.crisper.js",

+ IDR_MD_HISTORY_LAZY_LOAD_CRISPER_JS);

#else

source->AddResourcePath("app.html", IDR_MD_HISTORY_APP_HTML);

source->AddResourcePath("app.js", IDR_MD_HISTORY_APP_JS);

@@ -159,6 +163,7 @@ content::WebUIDataSource* CreateMdHistoryUIHTMLSource(Profile* profile) {

source->AddResourcePath("history_toolbar.js",

IDR_MD_HISTORY_HISTORY_TOOLBAR_JS);

source->AddResourcePath("icons.html", IDR_MD_HISTORY_ICONS_HTML);

+ source->AddResourcePath("lazy_load.html", IDR_MD_HISTORY_LAZY_LOAD_HTML);

source->AddResourcePath("list_container.html",

IDR_MD_HISTORY_LIST_CONTAINER_HTML);

source->AddResourcePath("list_container.js",