Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2264953003: Use testharness.js instead of js-test.js in OffscreenCanvas tests. (Closed)

Created:
4 years, 4 months ago by sivag
Modified:
4 years, 4 months ago
Reviewers:
Srirama, fs, Justin Novosad
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use testharness.js instead of js-test.js in OffscreenCanvas tests. This test changes test code to replace js-test.js functions with testharness.js asserts for OffscreenCanvas-currentColor and OffscreenCanvas-invalid-args tests.Remove the expectation files as they are not necessary now. BUG=639732 Committed: https://crrev.com/93beea417ece6db6f99e298e62aca36d81c24b02 Cr-Commit-Position: refs/heads/master@{#413488}

Patch Set 1 #

Patch Set 2 : Change attribute to plural. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -84 lines) Patch
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor.html View 1 1 chunk +13 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-currentColor-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args.html View 1 chunk +36 lines, -37 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/OffscreenCanvas-invalid-args-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
sivag
@fs, junov, ptal.. fs, this patch takes care of review comments given earlier.
4 years, 4 months ago (2016-08-22 12:59:24 UTC) #2
fs
lgtm
4 years, 4 months ago (2016-08-22 13:13:07 UTC) #5
Justin Novosad
On 2016/08/22 13:13:07, fs wrote: > lgtm lgtm
4 years, 4 months ago (2016-08-22 15:06:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264953003/20001
4 years, 4 months ago (2016-08-22 15:41:02 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-22 18:50:39 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 18:53:23 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93beea417ece6db6f99e298e62aca36d81c24b02
Cr-Commit-Position: refs/heads/master@{#413488}

Powered by Google App Engine
This is Rietveld 408576698