Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2264943002: Add UseCounters for name attribute matching of <map> and <input type=radio> (Closed)

Created:
4 years, 4 months ago by tkent
Modified:
4 years, 4 months ago
Reviewers:
Ilya Sherman, kochi
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UseCounters for name attribute matching of <map> and <input type=radio> https://github.com/whatwg/html/issues/1666 We'd like to know if Unicode caseless matching is really necessary for them. This CL adds the following counters of cases where: - Exact codepoint matching is enough - ASCII-caseless matching is enough - Otherwise for each of <map> and <input type=radio>. BUG=639477 Committed: https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072 Cr-Commit-Position: refs/heads/master@{#413538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M third_party/WebKit/Source/core/dom/TreeScope.cpp View 1 chunk +18 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp View 1 chunk +12 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tkent
kochi@, would you review third_party/WebKit/ please? isherman@, would you approve histograms.xml please?
4 years, 4 months ago (2016-08-22 07:14:51 UTC) #8
kochi
LGTM
4 years, 4 months ago (2016-08-22 16:42:53 UTC) #9
Ilya Sherman
histograms.xml lgtm
4 years, 4 months ago (2016-08-22 21:10:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264943002/1
4 years, 4 months ago (2016-08-22 21:24:17 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 21:31:29 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 21:33:34 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072
Cr-Commit-Position: refs/heads/master@{#413538}

Powered by Google App Engine
This is Rietveld 408576698