chrome/browser/resources/md_history/side_bar.js - Issue 2264933002: [MD History] Make sidebar menu respond to spacebar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/side_bar.js

Issue 2264933002: [MD History] Make sidebar menu respond to spacebar. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fix_presubmit

Patch Set: use IronA11yKeysBehavior Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/side_bar.html ('K') | « chrome/browser/resources/md_history/side_bar.html ('k') | chrome/test/data/webui/md_history/history_routing_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/side_bar.js

diff --git a/chrome/browser/resources/md_history/side_bar.js b/chrome/browser/resources/md_history/side_bar.js

index a652263760e398ec0482673df52f6596cd4f1e01..af89170d3640543299989611ddf2e6a4607bb4cd 100644

--- a/chrome/browser/resources/md_history/side_bar.js

+++ b/chrome/browser/resources/md_history/side_bar.js

@@ -5,6 +5,8 @@

Polymer({

is: 'history-side-bar',

+ behaviors: [Polymer.IronA11yKeysBehavior],

properties: {

selectedPage: {type: String, notify: true},

@@ -16,6 +18,18 @@ Polymer({

drawer: {type: Boolean, reflectToAttribute: true},

+ keyBindings: {

+ 'space:keydown': 'onSpacePressed_',

+ },

+ /**

+ * @param {CustomEvent} e

+ * @private

+ */

+ onSpacePressed_: function(e) {

+ e.detail.keyboardEvent.path[0].click();

+ },

/**

* @private