[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

test/mjsunit/asm/asm-validation.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Flags: --validate-asm --allow-natives-syntax
 
-function IsAlwaysOpt(module) {
-  return %GetOptimizationStatus(module) === 3;
+function assertValidAsm(func) {
+  assertTrue(%IsAsmWasmCode(func) ||
+             %GetOptimizationStatus(func) === 3);
 }
 
 (function TestModuleArgs() {
   function Module1(stdlib) {
     "use asm";
     function foo() { }
     return { foo: foo };
   }
   function Module2(stdlib, ffi) {
     "use asm";
     function foo() { }
     return { foo: foo };
   }
   function Module3(stdlib, ffi, heap) {
     "use asm";
     function foo() { }
     return { foo: foo };
   }
   var modules = [Module1, Module2, Module3];
   var heap = new ArrayBuffer(1024 * 1024);
   for (var i = 0; i < modules.length; ++i) {
     print('Module' + (i + 1));
     var module = modules[i];
-    // TODO(bradnelson): Support modules without the stdlib.
+    var m = module();
+    assertValidAsm(module);
     var m = module({});
-    assertTrue(%IsAsmWasmCode(module) || IsAlwaysOpt(module));
+    assertValidAsm(module);
     var m = module({}, {});
-    assertTrue(%IsAsmWasmCode(module) || IsAlwaysOpt(module));
+    assertValidAsm(module);
     var m = module({}, {}, heap);
-    assertTrue(%IsAsmWasmCode(module) || IsAlwaysOpt(module));
+    assertValidAsm(module);
     var m = module({}, {}, heap, {});
-    assertTrue(%IsAsmWasmCode(module) || IsAlwaysOpt(module));
+    assertValidAsm(module);
   }
 })();
 
 (function TestBadModule() {
   function Module(stdlib, ffi, heap) {
     "use asm";
     function foo() { var y = 3; var x = 1 + y; return 123; }
     return { foo: foo };
   }
   var m = Module({});
   assertFalse(%IsAsmWasmCode(Module));
   assertEquals(123, m.foo());
 })();
 
 (function TestBadArgTypes() {
   function Module(a, b, c) {
     "use asm";
+    var NaN = a.NaN;
     return {};
   }
   var m = Module(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module));
   assertEquals({}, m);
 })();
 
 (function TestBadArgTypesMismatch() {
   function Module(a, b, c) {
     "use asm";
+    var NaN = a.NaN;
     return {};
   }
   var m = Module(1, 2);
   assertFalse(%IsAsmWasmCode(Module));
   assertEquals({}, m);
 })();
 
 (function TestModuleNoStdlib() {
-  // TODO(bradnelson):
-  // Support modules like this if they don't use the whole stdlib.
   function Module() {
     "use asm";
     function foo() { return 123; }
     return { foo: foo };
   }
   var m = Module({});
-  assertFalse(%IsAsmWasmCode(Module));
+  assertValidAsm(Module);
   assertEquals(123, m.foo());
 })();
 
 (function TestModuleWith5() {
   function Module(a, b, c, d, e) {
     "use asm";
     function foo() { return 123; }
     return { foo: foo };
   }
   var heap = new ArrayBuffer(1024 * 1024);
   var m = Module({}, {}, heap);
   assertFalse(%IsAsmWasmCode(Module));
   assertEquals(123, m.foo());
 })();
 
 (function TestModuleNoStdlibCall() {
   function Module(stdlib, ffi, heap) {
     "use asm";
     function foo() { return 123; }
     return { foo: foo };
   }
-  // TODO(bradnelson): Support instantiation like this if stdlib is unused.
   var m = Module();
-  assertFalse(%IsAsmWasmCode(Module));
+  assertValidAsm(Module);
   assertEquals(123, m.foo());
 })();
 
 (function TestModuleNew() {
   function Module(stdlib, ffi, heap) {
     "use asm";
     function foo() { return 123; }
     return { foo: foo };
   }
   var m = new Module({}, {});
-  assertTrue(%IsAsmWasmCode(Module) || IsAlwaysOpt(Module));
+  assertValidAsm(Module);
   assertEquals(123, m.foo());
 })();
 
 (function TestMultipleFailures() {
   function Module(stdlib) {
     "use asm";
+    var NaN = stdlib.NaN;
     function foo() { return 123; }
     return { foo: foo };
   }
   var m1 = Module(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module));
   var m2 = Module(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module));
   assertEquals(123, m1.foo());
   assertEquals(123, m2.foo());
 })();
 
 (function TestFailureThenSuccess() {
   function MkModule() {
     function Module(stdlib, ffi, heap) {
       "use asm";
+      var NaN = stdlib.NaN;
       function foo() { return 123; }
       return { foo: foo };
     }
     return Module;
   }
   var Module1 = MkModule();
   var Module2 = MkModule();
   var heap = new ArrayBuffer(1024 * 1024);
   var m1 = Module1(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module1));
   var m2 = Module2({}, {}, heap);
   assertFalse(%IsAsmWasmCode(Module2));
   assertEquals(123, m1.foo());
   assertEquals(123, m2.foo());
 })();
 
 (function TestSuccessThenFailure() {
   function MkModule() {
     function Module(stdlib, ffi, heap) {
       "use asm";
+      var NaN = stdlib.NaN;
       function foo() { return 123; }
       return { foo: foo };
     }
     return Module;
   }
   var Module1 = MkModule();
   var Module2 = MkModule();
   var heap = new ArrayBuffer(1024 * 1024);
-  var m1 = Module1({}, {}, heap);
-  assertTrue(%IsAsmWasmCode(Module1) || IsAlwaysOpt(Module1));
+  var m1 = Module1({NaN: NaN}, {}, heap);
+  assertValidAsm(Module1);
   var m2 = Module2(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module2));
   assertEquals(123, m1.foo());
   assertEquals(123, m2.foo());
 })();
 
 (function TestSuccessThenFailureThenRetry() {
   function MkModule() {
     function Module(stdlib, ffi, heap) {
       "use asm";
+      var NaN = stdlib.NaN;
       function foo() { return 123; }
       return { foo: foo };
     }
     return Module;
   }
   var Module1 = MkModule();
   var Module2 = MkModule();
   var heap = new ArrayBuffer(1024 * 1024);
-  var m1a = Module1({}, {}, heap);
-  assertTrue(%IsAsmWasmCode(Module1) || IsAlwaysOpt(Module1));
+  var m1a = Module1({NaN: NaN}, {}, heap);
+  assertValidAsm(Module1);
   var m2 = Module2(1, 2, 3);
   assertFalse(%IsAsmWasmCode(Module2));
-  var m1b = Module1({}, {}, heap);
+  var m1b = Module1({NaN: NaN}, {}, heap);
   assertFalse(%IsAsmWasmCode(Module1));
   assertEquals(123, m1a.foo());
   assertEquals(123, m1b.foo());
   assertEquals(123, m2.foo());
 })();
 
 (function TestBoundFunction() {
   function Module(stdlib, ffi, heap) {
     "use asm";
     function foo() { return 123; }
     return { foo: foo };
   }
   var heap = new ArrayBuffer(1024 * 1024);
   var ModuleBound = Module.bind(this, {}, {}, heap);
   var m = ModuleBound();
-  assertTrue(%IsAsmWasmCode(Module) || IsAlwaysOpt(Module));
+  assertValidAsm(Module);
   assertEquals(123, m.foo());
 })();