[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/e5f5ac7d2bbab16d0f83edb6d030dfcd1a28e71f
Cr-Commit-Position: refs/heads/master@{#38806}

[bradnelson, 2016-08-22 01:02:08]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 01:02:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-08-22 01:04:47]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-08-22 01:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 01:24:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[bradnelson, 2016-08-22 01:32:29]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 01:32:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 01:52:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 01:52:47]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[bradnelson, 2016-08-22 02:23:45]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time. To reject modules that import a
function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[bradnelson, 2016-08-22 02:24:01]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 02:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-08-22 02:24:26]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time. To reject modules that import a
function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[bradnelson, 2016-08-22 02:26:54]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object close to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object to be closer to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[bradnelson, 2016-08-22 02:28:28]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface of the Wasm object to be closer to spec and
to move asm.js testing to asm.js coming in through the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-08-22 02:38:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 02:38:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[bradnelson, 2016-08-22 03:08:16]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 03:08:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 03:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 03:21:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[bradnelson, 2016-08-22 03:58:07]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 03:58:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 04:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 04:18:40]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-08-22 04:19:34]

PTAL

[titzer, 2016-08-22 08:37:52]

lgtm with nit

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-592352.js (right):

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-592352.js:17: %GetOptimizationStatus(__f_76) ===
3);
Maybe we want a runtime call that encapsulates this predicate, since it's
proliferated into a lot of regression tests?

[Michael Starzinger, 2016-08-22 11:45:59]

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-592352.js (right):

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-592352.js:17: %GetOptimizationStatus(__f_76) ===
3);
On 2016/08/22 08:37:51, titzer wrote:
> Maybe we want a runtime call that encapsulates this predicate, since it's
> proliferated into a lot of regression tests?

+1. Also if/when we change the pipeline to avoid optimizing asm.js module
instantiation code via --always-opt in the first place, we don't want to touch
all this places again. Could we just make the %IsAsmWasmCode predicate return
true in --always-opt mode for now? You can leave a TODO(mstarzinger) there.

[bradnelson, 2016-08-22 23:04:01]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:04:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 23:31:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 23:31:03]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)

[bradnelson, 2016-08-22 23:33:15]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-22 23:33:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:10:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:10:09]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
  v8_win_nosnap_shared_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[bradnelson, 2016-08-23 00:22:22]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 00:22:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:37:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:37:26]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[bradnelson, 2016-08-23 03:16:23]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 03:16:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 03:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 03:58:12]

Dry run: This issue passed the CQ dry run.

[bradnelson, 2016-08-23 04:04:43]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2016-08-23 04:04:43]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2264913002/#ps160001
(title: "fix")

[commit-bot: I haz the power, 2016-08-23 04:04:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bradnelson, 2016-08-23 04:04:56]

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
File test/mjsunit/regress/regress-592352.js (right):

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-592352.js:17: %GetOptimizationStatus(__f_76) ===
3);
On 2016/08/22 08:37:51, titzer wrote:
> Maybe we want a runtime call that encapsulates this predicate, since it's
> proliferated into a lot of regression tests?

Done.

https://codereview.chromium.org/2264913002/diff/80001/test/mjsunit/regress/re...
test/mjsunit/regress/regress-592352.js:17: %GetOptimizationStatus(__f_76) ===
3);
On 2016/08/22 11:45:59, Michael Starzinger wrote:
> On 2016/08/22 08:37:51, titzer wrote:
> > Maybe we want a runtime call that encapsulates this predicate, since it's
> > proliferated into a lot of regression tests?
> 
> +1. Also if/when we change the pipeline to avoid optimizing asm.js module
> instantiation code via --always-opt in the first place, we don't want to touch
> all this places again. Could we just make the %IsAsmWasmCode predicate return
> true in --always-opt mode for now? You can leave a TODO(mstarzinger) there.

Done.

[commit-bot: I haz the power, 2016-08-23 04:06:59]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

[commit-bot: I haz the power, 2016-08-23 04:07:00]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-08-23 04:07:34]

Description was changed from

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org
==========

to

==========
[wasm] asm.js - Remove Wasm.instantiateModuleFromAsm, use asm.js directly.

Make use of %IsAsmWasmCode in place of Wasm.instantiateModuleFromAsm,
in order to reduce the surface area of the Wasm object,
and to focus on testing asm.js coming in via the parser.

Ignore extra CONST_LEGACY assignment introduced by the parser
when modules have the form:
(function Foo(a, b, c) {..});
This requires both a validator and AsmWasmBuilder change.

Move stdlib use collection to import time,
to reject modules that import a function, even if not used.

BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203
LOG=N
R=jpp@chromium.org,titzer@chromium.org

Committed: https://crrev.com/e5f5ac7d2bbab16d0f83edb6d030dfcd1a28e71f
Cr-Commit-Position: refs/heads/master@{#38806}
==========

[commit-bot: I haz the power, 2016-08-23 04:07:35]

Patchset 9 (id:??) landed as
https://crrev.com/e5f5ac7d2bbab16d0f83edb6d030dfcd1a28e71f
Cr-Commit-Position: refs/heads/master@{#38806}