Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3207)

Unified Diff: chrome/browser/ui/search/new_tab_page_interceptor_service.cc

Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead
Patch Set: fix while loop Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_resource_throttle_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/new_tab_page_interceptor_service.cc
diff --git a/chrome/browser/ui/search/new_tab_page_interceptor_service.cc b/chrome/browser/ui/search/new_tab_page_interceptor_service.cc
index 4f819b94ab73c8a4071763da9bf44b0d22d9692a..2774a3ab32fe2dc66ea01711984d9bf2f0286312 100644
--- a/chrome/browser/ui/search/new_tab_page_interceptor_service.cc
+++ b/chrome/browser/ui/search/new_tab_page_interceptor_service.cc
@@ -65,6 +65,8 @@ class NewTabPageInterceptor : public net::URLRequestInterceptor {
return nullptr;
}
// User has canceled this navigation so it shouldn't be redirected.
+ // TODO(maksims): Remove request->status() and use int net_error
+ // once MaybeInterceptResponse() starts to pass that.
if (request->status().status() == net::URLRequestStatus::CANCELED ||
(request->status().status() == net::URLRequestStatus::FAILED &&
request->status().error() == net::ERR_ABORTED)) {
@@ -72,6 +74,8 @@ class NewTabPageInterceptor : public net::URLRequestInterceptor {
}
// Request to NTP was successful.
+ // TODO(maksims): Remove request->status() and use int net_error
+ // once MaybeInterceptResponse() starts to pass that.
if (request->status().is_success() &&
request->GetResponseCode() != net::HTTP_NO_CONTENT &&
request->GetResponseCode() < 400) {
« no previous file with comments | « chrome/browser/prerender/prerender_resource_throttle_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698