chrome/browser/predictors/resource_prefetcher.h - Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/predictors/resource_prefetcher.h

Issue 2264903003: Adjust callers and networking delegates in chrome/ to modified APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@URLRequestRead

Patch Set: fix while loop Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/predictors/resource_prefetch_predictor_unittest.cc ('k') | chrome/browser/predictors/resource_prefetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/predictors/resource_prefetcher.h

diff --git a/chrome/browser/predictors/resource_prefetcher.h b/chrome/browser/predictors/resource_prefetcher.h

index ea548440a79dfa5b8f2b48ec50dcfd0f09eebc53..b92e4dca247ae967a30d01f5ad5e9f18560a4ab9 100644

--- a/chrome/browser/predictors/resource_prefetcher.h

+++ b/chrome/browser/predictors/resource_prefetcher.h

@@ -81,10 +81,6 @@ class ResourcePrefetcher : public net::URLRequest::Delegate {

// be cached correctly. Stubbed out during testing.

virtual void ReadFullResponse(net::URLRequest* request);

- // Returns true if the request has more data that needs to be read. If it

- // returns false, the request should not be referenced again.

- bool ShouldContinueReadingRequest(net::URLRequest* request, int bytes_read);

// net::URLRequest::Delegate methods.

void OnReceivedRedirect(net::URLRequest* request,

const net::RedirectInfo& redirect_info,

@@ -97,7 +93,7 @@ class ResourcePrefetcher : public net::URLRequest::Delegate {

void OnSSLCertificateError(net::URLRequest* request,

const net::SSLInfo& ssl_info,

bool fatal) override;

- void OnResponseStarted(net::URLRequest* request) override;

+ void OnResponseStarted(net::URLRequest* request, int net_error) override;

void OnReadCompleted(net::URLRequest* request, int bytes_read) override;

enum PrefetcherState {