Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 22649003: Have the Performance interface inherit EventTarget (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebaseline additional w3c test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/deprecated_code_generator_v8.pm
diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm
index ce077eefbe1f6408512706df8333bc54ee016185..ccb77497b11febcdc7e0570c06c30c8840e399ed 100644
--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm
+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm
@@ -913,17 +913,6 @@ END
}
}
-sub HasEventHandlerAttribute
-{
- my $interface = shift;
-
- foreach my $attribute (@{$interface->attributes}) {
- return 1 if $attribute->type eq "EventHandler";
- }
-
- return 0;
-}
-
sub GetInternalFields
{
my $interface = shift;
@@ -931,7 +920,7 @@ sub GetInternalFields
my @customInternalFields = ();
# Event listeners on DOM nodes are explicitly supported in the GC controller.
if (!InheritsInterface($interface, "Node") &&
- (InheritsInterface($interface, "EventTarget") || HasEventHandlerAttribute($interface))) {
+ InheritsInterface($interface, "EventTarget")) {
push(@customInternalFields, "eventListenerCacheIndex");
}
return @customInternalFields;

Powered by Google App Engine
This is Rietveld 408576698