Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2264873002: Revert "Add new feature flag to enable background loader for downloads" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1705 matching lines...) Expand 10 before | Expand all | Expand 10 after
1716 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME, 1716 {"offline-bookmarks", IDS_FLAGS_OFFLINE_BOOKMARKS_NAME,
1717 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid, 1717 IDS_FLAGS_OFFLINE_BOOKMARKS_DESCRIPTION, kOsAndroid,
1718 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)}, 1718 FEATURE_VALUE_TYPE(offline_pages::kOfflineBookmarksFeature)},
1719 {"offline-pages-background-loading", 1719 {"offline-pages-background-loading",
1720 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME, 1720 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_NAME,
1721 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid, 1721 IDS_FLAGS_OFFLINE_PAGES_BACKGROUND_LOADING_DESCRIPTION, kOsAndroid,
1722 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)}, 1722 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesBackgroundLoadingFeature)},
1723 {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME, 1723 {"offline-pages-sharing", IDS_FLAGS_OFFLINE_PAGES_SHARING_NAME,
1724 IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid, 1724 IDS_FLAGS_OFFLINE_PAGES_SHARING_DESCRIPTION, kOsAndroid,
1725 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)}, 1725 FEATURE_VALUE_TYPE(offline_pages::kOfflinePagesSharingFeature)},
1726 {"background-loader-for-downloads",
1727 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_NAME,
1728 IDS_FLAGS_BACKGROUND_LOADER_FOR_DOWNLOADS_DESCRIPTION, kOsAndroid,
1729 FEATURE_VALUE_TYPE(
1730 offline_pages::kBackgroundLoaderForDownloadsFeature)},
1731 #endif // defined(OS_ANDROID) 1726 #endif // defined(OS_ANDROID)
1732 {"disallow-doc-written-script-loads", 1727 {"disallow-doc-written-script-loads",
1733 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_NAME, 1728 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_NAME,
1734 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_DESCRIPTION, kOsAll, 1729 IDS_FLAGS_DISALLOW_DOC_WRITTEN_SCRIPTS_UI_DESCRIPTION, kOsAll,
1735 // NOTE: if we want to add additional experiment entries for other 1730 // NOTE: if we want to add additional experiment entries for other
1736 // features controlled by kBlinkSettings, we'll need to add logic to 1731 // features controlled by kBlinkSettings, we'll need to add logic to
1737 // merge the flag values. 1732 // merge the flag values.
1738 SINGLE_VALUE_TYPE_AND_VALUE( 1733 SINGLE_VALUE_TYPE_AND_VALUE(
1739 switches::kBlinkSettings, 1734 switches::kBlinkSettings,
1740 "disallowFetchForDocWrittenScriptsInMainFrame=true")}, 1735 "disallowFetchForDocWrittenScriptsInMainFrame=true")},
(...skipping 524 matching lines...) Expand 10 before | Expand all | Expand 10 after
2265 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2260 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2266 2261
2267 const FeatureEntry* GetFeatureEntries(size_t* count) { 2262 const FeatureEntry* GetFeatureEntries(size_t* count) {
2268 *count = arraysize(kFeatureEntries); 2263 *count = arraysize(kFeatureEntries);
2269 return kFeatureEntries; 2264 return kFeatureEntries;
2270 } 2265 }
2271 2266
2272 } // namespace testing 2267 } // namespace testing
2273 2268
2274 } // namespace about_flags 2269 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/android/chrome_feature_list.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698