Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: trunk/src/ui/compositor/compositor.h

Issue 22648006: Revert 216780 "Clean up compositor initialization/destruction." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/ui/aura/test/test_suite.cc ('k') | trunk/src/ui/compositor/compositor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ui/compositor/compositor.h
===================================================================
--- trunk/src/ui/compositor/compositor.h (revision 216906)
+++ trunk/src/ui/compositor/compositor.h (working copy)
@@ -99,10 +99,6 @@
// Destroys per-compositor data.
virtual void RemoveCompositor(Compositor* compositor) = 0;
-
- // When true, the factory uses test contexts that do not do real GL
- // operations.
- virtual bool DoesCreateTestContexts() = 0;
};
// The default factory that creates in-process contexts.
@@ -127,7 +123,6 @@
virtual scoped_refptr<cc::ContextProvider>
OffscreenContextProviderForCompositorThread() OVERRIDE;
virtual void RemoveCompositor(Compositor* compositor) OVERRIDE;
- virtual bool DoesCreateTestContexts() OVERRIDE;
bool Initialize();
@@ -166,7 +161,6 @@
virtual scoped_refptr<cc::ContextProvider>
OffscreenContextProviderForCompositorThread() OVERRIDE;
virtual void RemoveCompositor(Compositor* compositor) OVERRIDE;
- virtual bool DoesCreateTestContexts() OVERRIDE;
private:
scoped_refptr<ContextProviderFromContextFactory>
@@ -296,14 +290,6 @@
gfx::AcceleratedWidget widget);
virtual ~Compositor();
- // Set up the compositor ContextFactory for a test environment. Unit tests
- // that do not have a full content environment need to call this before
- // initializing the Compositor.
- // Some tests expect pixel output, and they should pass false for
- // |allow_test_contexts|. Most unit tests should pass true. Once this has been
- // called, the Initialize() and Terminate() methods should be used as normal.
- static void InitializeContextFactoryForTests(bool allow_test_contexts);
-
static void Initialize();
static bool WasInitializedWithThread();
static scoped_refptr<base::MessageLoopProxy> GetCompositorMessageLoop();
Property changes on: trunk/src/ui/compositor/compositor.h
___________________________________________________________________
Deleted: svn:mergeinfo
« no previous file with comments | « trunk/src/ui/aura/test/test_suite.cc ('k') | trunk/src/ui/compositor/compositor.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698