Revert 216780 "Clean up compositor initialization/destruction."

Revert 216780 "Clean up compositor initialization/destruction."

> Clean up compositor initialization/destruction.
> 
> Moved from https://codereview.chromium.org/21052007/
> 
> Currently the ContextFactory is outliving the compositor thread in 
> tests, which is bad since the contexts in there can be bound to the 
> compositor thread. Then we end up reusing those contexts and bad 
> things happen. 
> 
> This enforces ordering for initializing and destroying the 
> compositor as follows: 
> 
> Initialize ContextFactory 
> ..Compositor::Initialize 
> ....Create Compositor instances 
> ....Delete Compositor instances 
> ..Compositor::Terminate 
> 
> The Compositor::Terminate call also destroys the ContextFactory. 
> 
> The ContextFactory can be initialized in one of two ways: 
> 1. ImageTransportFactory::Initialize will set up the 
> ContextFactory. This is used by things that invoke all of 
> content/browser/. 
> 2. Compositor::InitializeContextFactoryForTests() must be 
> explicitly called by any unit tests that create a compositor. 
> 
> Since some tests want a real GL context and some don't, this 
> does away with the misnomer of initializing the Compositor once 
> for the entire test suite, and then re-initializing somewhere 
> in the middle of the test suite. Instead, each test must 
> Initialize/Terminate the compositor with the ContextFactory 
> type of its choice. 
> 
> Incidently, this test enables 20 tests on aura or win_aura that 
> were previously being skipped. 
> 
> TBR=piman@chromium.org
> BUG=258625
> 
> Review URL: https://chromiumcodereview.appspot.com/22293003

TBR=danakj@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216907

[nhiroki, 2013-08-12 03:41:39]

Committed patchset #1 manually as r216907.

[danakj, 2013-08-12 05:20:06]

It would be nice to explain why you are reverting something with some links
when you do so?
On Aug 11, 2013 11:40 PM, <nhiroki@chromium.org> wrote:

> Reviewers: danakj,
>
> Description:
> Revert 216780 "Clean up compositor initialization/destruction."
>
>  Clean up compositor initialization/destruction.
>>
>
>  Moved from
https://codereview.chromium.**org/21052007/<https://codereview.chromium.org/2...
>>
>
>  Currently the ContextFactory is outliving the compositor thread in
>> tests, which is bad since the contexts in there can be bound to the
>> compositor thread. Then we end up reusing those contexts and bad
>> things happen.
>>
>
>  This enforces ordering for initializing and destroying the
>> compositor as follows:
>>
>
>  Initialize ContextFactory
>> ..Compositor::Initialize
>> ....Create Compositor instances
>> ....Delete Compositor instances
>> ..Compositor::Terminate
>>
>
>  The Compositor::Terminate call also destroys the ContextFactory.
>>
>
>  The ContextFactory can be initialized in one of two ways:
>> 1. ImageTransportFactory::**Initialize will set up the
>> ContextFactory. This is used by things that invoke all of
>> content/browser/.
>> 2. Compositor::**InitializeContextFactoryForTes**ts() must be
>> explicitly called by any unit tests that create a compositor.
>>
>
>  Since some tests want a real GL context and some don't, this
>> does away with the misnomer of initializing the Compositor once
>> for the entire test suite, and then re-initializing somewhere
>> in the middle of the test suite. Instead, each test must
>> Initialize/Terminate the compositor with the ContextFactory
>> type of its choice.
>>
>
>  Incidently, this test enables 20 tests on aura or win_aura that
>> were previously being skipped.
>>
>
>  TBR=piman@chromium.org
>> BUG=258625
>>
>
>  Review URL:
https://chromiumcodereview.**appspot.com/22293003<https://chromiumcodereview....
>>
>
> TBR=danakj@chromium.org
>
> Please review this at
https://codereview.chromium.**org/22648006/<https://codereview.chromium.org/2...
>
> SVN Base: svn://svn.chromium.org/chrome/
>
> Affected files:
>   M     trunk/src/ash/test/test_shell_**delegate.cc
>   M     trunk/src/ash/test/test_suite.**cc
>   M     trunk/src/chrome/browser/**chromeos/extensions/file_**
> manager/file_manager_**browsertest.cc
>   M     trunk/src/chrome/browser/**extensions/api/tab_capture/**
> tab_capture_apitest.cc
>   M     trunk/src/chrome/browser/**extensions/api/webstore_**
> private/webstore_private_**apitest.cc
>   M     trunk/src/chrome/browser/**extensions/extension_resource_**
> request_policy_apitest.cc
>   M     trunk/src/chrome/browser/**extensions/requirements_**
> checker_browsertest.cc
>   M     trunk/src/chrome/browser/**extensions/web_view_**browsertest.cc
>   M     trunk/src/chrome/browser/**prerender/prerender_**browsertest.cc
>   M     trunk/src/chrome/browser/ui/**ash/ash_init.cc
>   M     trunk/src/chrome/browser/ui/**views/tabs/tab_drag_**
> controller_interactive_uitest.**h
>   M     trunk/src/chrome/browser/ui/**views/tabs/tab_drag_**
> controller_interactive_uitest.**cc
>   M     trunk/src/chrome/test/base/in_**process_browser_test.cc
>   M     trunk/src/chrome/test/base/**test_launcher_utils.h
>   M     trunk/src/chrome/test/base/**test_launcher_utils.cc
>   M     trunk/src/chrome/test/base/**view_event_test_base.cc
>   M     trunk/src/chrome/test/gpu/gpu_**feature_browsertest.cc
>   M     trunk/src/chrome/test/gpu/**webgl_infobar_browsertest.cc
>   M     trunk/src/chrome/test/ppapi/**ppapi_test.cc
>   M     trunk/src/chrome/test/ui/ui_**test.cc
>   M     trunk/src/components/test/run_**all_unittests.cc
>   M     trunk/src/content/browser/**aura/gpu_process_transport_**factory.h
>   M     trunk/src/content/browser/**aura/gpu_process_transport_**
> factory.cc
>   M     trunk/src/content/browser/**aura/image_transport_factory.**cc
>   M     trunk/src/content/browser/**browser_plugin/browser_plugin_**
> host_browsertest.cc
>   M     trunk/src/content/browser/gpu/**gpu_info_browsertest.cc
>   M     trunk/src/content/browser/gpu/**gpu_ipc_browsertests.cc
>   M     trunk/src/content/browser/gpu/**gpu_pixel_browsertest.cc
>   M     trunk/src/content/browser/**media/media_browsertest.h
>   M     trunk/src/content/browser/**media/media_browsertest.cc
>   M     trunk/src/content/browser/**renderer_host/render_widget_**
> host_view_browsertest.cc
>   MM    trunk/src/content/browser/web_**contents/web_contents_view_**
> aura_browsertest.cc
>   MM    trunk/src/content/common/gpu/**client/gl_helper.h
>   MM    trunk/src/content/common/gpu/**client/gl_helper.cc
>   MM    trunk/src/content/public/test/**browser_test_base.h
>   MM    trunk/src/content/public/test/**browser_test_base.cc
>   MM    trunk/src/content/public/test/**content_test_suite_base.cc
>   MM    trunk/src/ui/aura/test/aura_**test_helper.cc
>   MM    trunk/src/ui/aura/test/test_**suite.cc
>   MM    trunk/src/ui/compositor/**compositor.cc
>   MM    trunk/src/ui/compositor/**compositor.gyp
>   MM    trunk/src/ui/compositor/**compositor.h
>   A  +  trunk/src/ui/compositor/**compositor_setup.h
>   MM    trunk/src/ui/compositor/layer_**unittest.cc
>   MM    trunk/src/ui/compositor/test/**test_suite.cc
>   MM    trunk/src/ui/keyboard/**keyboard_test_suite.cc
>   MM    trunk/src/ui/message_center/**test/run_all_unittests.cc
>   MM    trunk/src/ui/snapshot/**snapshot_aura_unittest.cc
>   MM    trunk/src/ui/views/run_all_**unittests.cc
>   MM    trunk/src/ui/views/widget/**desktop_aura/desktop_capture_**
> client_unittest.cc
>
>
>

[nhiroki, 2013-08-12 05:55:17]

On 2013/08/12 05:20:06, danakj wrote:
> It would be nice to explain why you are reverting something with some links
> when you do so?
> On Aug 11, 2013 11:40 PM, <mailto:nhiroki@chromium.org> wrote:

Sorry, I forgot to explain the reason...

As fmalita@ mentioned in the original review
(https://chromiumcodereview.appspot.com/22293003),
this might cause NetInternalsTest.netInternalsTimelineViewScrollbar failure on
Win Aura Tests.

http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%283%2...
http://build.chromium.org/p/chromium.win/builders/Win%20Aura%20Tests%20%282%2...

Thanks,
nhiroki