Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 2264773002: Preventing MIPS builds from attempting to copy missing file (Closed)

Created:
4 years, 4 months ago by bajones
Modified:
4 years, 4 months ago
Reviewers:
bshe
CC:
chromium-reviews, Donn Denman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Preventing MIPS builds from attempting to copy missing file This build target should never be reached on MIPS builds, but apparently it's doing an early check to ensure the file exists anyway. BUG=639472 TBR=bshe@chromium.org Committed: https://crrev.com/d11732fe29ceab8a70a174b23b1820fcb2154cfa Cr-Commit-Position: refs/heads/master@{#413362}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M third_party/gvr-android-sdk/BUILD.gn View 1 chunk +15 lines, -11 lines 0 comments Download

Messages

Total messages: 30 (15 generated)
bajones
bshe@: I think this should be more effective from really truly actually excluding this particular ...
4 years, 4 months ago (2016-08-19 22:14:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-19 22:28:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126311)
4 years, 4 months ago (2016-08-20 02:40:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-20 03:06:08 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126397)
4 years, 4 months ago (2016-08-20 05:20:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-20 14:54:48 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126550)
4 years, 4 months ago (2016-08-20 15:38:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-20 16:27:08 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/126577)
4 years, 4 months ago (2016-08-20 17:51:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-21 00:31:15 UTC) #21
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-21 02:49:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264773002/1
4 years, 4 months ago (2016-08-21 02:54:24 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 02:57:15 UTC) #27
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d11732fe29ceab8a70a174b23b1820fcb2154cfa Cr-Commit-Position: refs/heads/master@{#413362}
4 years, 4 months ago (2016-08-21 02:58:28 UTC) #29
bshe
4 years, 4 months ago (2016-08-22 13:37:56 UTC) #30
Message was sent while issue was closed.
On 2016/08/21 02:58:28, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/d11732fe29ceab8a70a174b23b1820fcb2154cfa
> Cr-Commit-Position: refs/heads/master@{#413362}

lgtm

Powered by Google App Engine
This is Rietveld 408576698