components/arc/common/wallpaper.mojom - Issue 2264743002: cheets: implement cros side of WallpaperManagerService.

Side by Side Diff: components/arc/common/wallpaper.mojom

Issue 2264743002: cheets: implement cros side of WallpaperManagerService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: cheets: implement cros side of WallpaperManagerService. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/chromeos/arc/arc_wallpaper_service.cc ('K') | « components/arc/common/arc_bridge.mojom ('k') | components/arc/intent_helper/arc_intent_helper_bridge.h » ('j') | components/arc/set_wallpaper_delegate.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4 //

	5 // Next MinVersion: 1

	6

	7 module arc.mojom;

	8

	9 // Handles wallpaper calls from ARC in Chrome.

	10 // Next method ID:2

	11 interface WallpaperHost {

	12 // Gets current wallpaper encoded in PNG and send it back to ARC.

	13 GetWallpaper@0() => (array<uint8> wallpaper);

	14

	15 // Sets an image from ARC as the wallpaper.

	16 // \|png_data\| is a PNG encoded wallpaper image.

	17 SetWallpaper@1(array<uint8> png_data);
	hidehiko 2016/09/02 05:07:13 Clarification: I'd like to know the clean-up plan. Clarification: I'd like to know the clean-up plan. So the plan is merging IntentHelper's SetWallpaper to here. IntentHelper's one supports JPEG and this supports PNG. Who'll convert the image? I thought there could be several approaches; 1) Convert image format in ARC container (JPEG -> PNG). Then I'm fine with this API. 2) Pass through the image as is via Mojo, and in ArcWallpaperService, decode images based on the format. Then, it's better to add file format to the API. Or, alternatively you may be able to detect the file format by, e.g., magic. 3) Decode image in ARC container (JPEG -> Bitmap, PNG -> Bitmap). Then the file format should be bitmap, here. The pros is simplicity, but the cons is that the data will be bigger. WDYT? Luis Héctor Chávez 2016/09/02 16:23:48 The intention is to drop the IntentHelper's SetWal Show quoted text On 2016/09/02 05:07:13, hidehiko wrote: > Clarification: I'd like to know the clean-up plan. > > So the plan is merging IntentHelper's SetWallpaper to here. IntentHelper's one > supports JPEG and this supports PNG. Who'll convert the image? I thought there > could be several approaches; > 1) Convert image format in ARC container (JPEG -> PNG). Then I'm fine with this > API. > 2) Pass through the image as is via Mojo, and in ArcWallpaperService, decode > images based on the format. Then, it's better to add file format to the API. Or, > alternatively you may be able to detect the file format by, e.g., magic. > 3) Decode image in ARC container (JPEG -> Bitmap, PNG -> Bitmap). Then the file > format should be bitmap, here. The pros is simplicity, but the cons is that the > data will be bigger. > > WDYT? The intention is to drop the IntentHelper's SetWallpaper altogether, so nobody will have to do JPEG encoding/decoding in the future :) Android's implementation of the IntentHelper will call the WallpaperManager directly instead of having a second way of setting the wallpaper. hidehiko 2016/09/06 05:19:58 Makes sense. Thank you for clarification. Show quoted text On 2016/09/02 16:23:48, Luis Héctor Chávez wrote: > On 2016/09/02 05:07:13, hidehiko wrote: > > Clarification: I'd like to know the clean-up plan. > > > > So the plan is merging IntentHelper's SetWallpaper to here. IntentHelper's one > > supports JPEG and this supports PNG. Who'll convert the image? I thought there > > could be several approaches; > > 1) Convert image format in ARC container (JPEG -> PNG). Then I'm fine with > this > > API. > > 2) Pass through the image as is via Mojo, and in ArcWallpaperService, decode > > images based on the format. Then, it's better to add file format to the API. > Or, > > alternatively you may be able to detect the file format by, e.g., magic. > > 3) Decode image in ARC container (JPEG -> Bitmap, PNG -> Bitmap). Then the > file > > format should be bitmap, here. The pros is simplicity, but the cons is that > the > > data will be bigger. > > > > WDYT? > > The intention is to drop the IntentHelper's SetWallpaper altogether, so nobody > will have to do JPEG encoding/decoding in the future :) Android's implementation > of the IntentHelper will call the WallpaperManager directly instead of having a > second way of setting the wallpaper. Makes sense. Thank you for clarification.
	18 };

	19

	20 // Connects with container side to publish wallpaper related intents.

	21 // Next method ID:1

	22 interface WallpaperInstance {

	23 // Establishes communication with the container side.

	24 Init@0(WallpaperHost host_ptr);

	25 };

OLD	NEW