Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2264723002: Fix int overflow in window.moveBy (Closed)

Created:
4 years, 4 months ago by eae
Modified:
4 years, 4 months ago
Reviewers:
pdr.
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, jbroman, Justin Novosad, Rik, f(malita), blink-reviews, danakj+watch_chromium.org, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix int overflow in window.moveBy Fix an int overflow bug in window.moveBy by changing it to saturate when performing addition though a new saturatedMove method on IntPoint, Rect. BUG=635799 R=pdr@chromium.org Committed: https://crrev.com/47e39c323732b04b595f7a46a225b3cd7e768567 Cr-Commit-Position: refs/heads/master@{#413885}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntPoint.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/geometry/IntRect.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
eae
4 years, 4 months ago (2016-08-19 20:29:34 UTC) #5
pdr.
On 2016/08/19 at 20:29:34, eae wrote: > LGTM
4 years, 4 months ago (2016-08-19 21:07:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264723002/1
4 years, 4 months ago (2016-08-19 21:15:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/277380)
4 years, 4 months ago (2016-08-19 22:33:20 UTC) #11
pdr.
On 2016/08/19 at 22:33:20, commit-bot wrote: > Try jobs failed on following builders: > win_chromium_rel_ng ...
4 years, 4 months ago (2016-08-19 22:46:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264723002/1
4 years, 4 months ago (2016-08-19 22:47:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/277558)
4 years, 4 months ago (2016-08-20 00:37:28 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264723002/20001
4 years, 4 months ago (2016-08-23 18:48:25 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-23 23:06:52 UTC) #21
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:08:27 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/47e39c323732b04b595f7a46a225b3cd7e768567
Cr-Commit-Position: refs/heads/master@{#413885}

Powered by Google App Engine
This is Rietveld 408576698