Resubmit 21609003: Move ExtensionError to extensions/, add error limits

extensions/browser/extension_error.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_EXTENSION_ERROR_H_
-#define CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_EXTENSION_ERROR_H_
+#ifndef EXTENSIONS_BROWSER_EXTENSION_ERROR_H_
+#define EXTENSIONS_BROWSER_EXTENSION_ERROR_H_
 
 #include <string>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/logging.h"
 #include "base/strings/string16.h"
 
 namespace extensions {
 
 class ExtensionError {
  public:
   enum Type {
     MANIFEST_PARSING_ERROR,
     JAVASCRIPT_RUNTIME_ERROR
   };
 
   virtual ~ExtensionError();
 
   virtual std::string PrintForTest() const;
 
   Type type() const { return type_; }
   const base::string16& source() const { return source_; }
   const base::string16& message() const { return message_; }
   const std::string& extension_id() const { return extension_id_; }
   bool from_incognito() const { return from_incognito_; }
 
  protected:
   ExtensionError(Type type,
+                 const std::string& extension_id,
                  bool from_incognito,
                  const base::string16& source,
                  const base::string16& message);
 
   // Which type of error this is.
   Type type_;
+  // The ID of the extension which caused the error.
+  std::string extension_id_;
   // Whether or not the error was caused while incognito.
   bool from_incognito_;
   // The source for the error; this can be a script, web page, or manifest file.
   // This is stored as a string (rather than a url) since it can be a Chrome
   // script file (e.g., event_bindings.js).
   base::string16 source_;
   // The error message itself.
   base::string16 message_;
-  // The ID of the extension which caused the error. This may be absent, since
-  // we can't always know the id (such as when a manifest fails to parse).
-  std::string extension_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionError);
 };
 
 class ManifestParsingError : public ExtensionError {
  public:
-  ManifestParsingError(bool from_incognito,
-                       const base::string16& source,
-                       const base::string16& message,
-                       size_t line_number);
+  ManifestParsingError(const std::string& extension_id,
+                       const base::string16& message);
   virtual ~ManifestParsingError();
 
   virtual std::string PrintForTest() const OVERRIDE;
-
-  size_t line_number() const { return line_number_; }
  private:
-  size_t line_number_;
-
   DISALLOW_COPY_AND_ASSIGN(ManifestParsingError);
 };
 
 class JavascriptRuntimeError : public ExtensionError {
  public:
   struct StackFrame {
     size_t line_number;
     size_t column_number;
     // This is stored as a string (rather than a url) since it can be a
     // Chrome script file (e.g., event_bindings.js).
@@ skipping 36 matching lines @@
 
   logging::LogSeverity level_;
   base::string16 execution_context_url_;
   StackTrace stack_trace_;
 
   DISALLOW_COPY_AND_ASSIGN(JavascriptRuntimeError);
 };
 
 }  // namespace extensions
 
-#endif  // CHROME_BROWSER_EXTENSIONS_ERROR_CONSOLE_EXTENSION_ERROR_H_
+#endif  // EXTENSIONS_BROWSER_EXTENSION_ERROR_H_