Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2264673003: Add override to AnalysisCanvas for new SkCanvas virtual, onDrawArc (Closed)

Created:
4 years, 4 months ago by bsalomon
Modified:
4 years, 4 months ago
Reviewers:
f(malita), reed1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add override to AnalysisCanvas for new SkCanvas virtual, onDrawArc BUG=skia:5227 Committed: https://crrev.com/ddb77370f463eae75c699c2b4e51851ea9d69371 Cr-Commit-Position: refs/heads/master@{#413440}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M skia/ext/analysis_canvas.h View 1 chunk +5 lines, -0 lines 0 comments Download
M skia/ext/analysis_canvas.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bsalomon
4 years, 4 months ago (2016-08-19 21:31:38 UTC) #3
reed1
lgtm
4 years, 4 months ago (2016-08-20 22:12:11 UTC) #5
f(malita)
lgtm
4 years, 4 months ago (2016-08-20 22:36:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264673003/1
4 years, 4 months ago (2016-08-22 13:14:39 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-22 14:21:39 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-22 14:22:35 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddb77370f463eae75c699c2b4e51851ea9d69371
Cr-Commit-Position: refs/heads/master@{#413440}

Powered by Google App Engine
This is Rietveld 408576698