third_party/WebKit/Source/core/layout/LayoutTheme.h - Issue 2264663002: Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.h

Issue 2264663002: Paint solid color backgrounds which are equivalent to locally attached into scrolling contents layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scrollcontent-paint-bg

Patch Set: Add test and only skip local equivalence if outline enters padding-box Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTheme.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.h b/third_party/WebKit/Source/core/layout/LayoutTheme.h

index 93d5d6c0c9fadd36973288f8e56c410cc2106793..bf7e678f105103cc762740bcb25d16a22e169cf2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTheme.h

+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.h

@@ -187,6 +187,8 @@ public:

virtual bool shouldUseFallbackTheme(const ComputedStyle&) const;

+ virtual bool themeDrawsFocusRing(const ComputedStyle&) const = 0;

protected:

// The platform selection color.

virtual Color platformActiveSelectionBackgroundColor() const;

@@ -199,8 +201,6 @@ protected:

virtual Color platformActiveListBoxSelectionForegroundColor() const;

virtual Color platformInactiveListBoxSelectionForegroundColor() const;

- virtual bool themeDrawsFocusRing(const ComputedStyle&) const = 0;

// Methods for each appearance value.

virtual void adjustCheckboxStyle(ComputedStyle&) const;

virtual void setCheckboxSize(ComputedStyle&) const { }