Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2264633003: Workaround for reading bad PageState from session history.

Created:
4 years, 4 months ago by Charlie Reis
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, darin-cc_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround for reading bad PageState from session history. If no history item is found for a subframe and the fallback URL is about:blank, the browser doesn't need to tell the renderer to load it again. BUG=638088 TEST=Load chrome://help, then chrome://restart. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M components/sessions/content/content_serialized_navigation_builder.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (5 generated)
Charlie Reis
Description was changed from ========== Workaround for reading bad PageState from session history. If no ...
4 years, 4 months ago (2016-08-20 03:57:27 UTC) #1
Charlie Reis
The CQ bit was checked by creis@chromium.org to run a CQ dry run
4 years, 4 months ago (2016-08-20 03:57:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264633003/1
4 years, 4 months ago (2016-08-20 03:57:47 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 4 months ago (2016-08-20 04:04:09 UTC) #4
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 04:04:10 UTC) #5
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698