Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2264593002:
Add GMs for testing drawArc (Closed)
DescriptionAdd GMs for testing drawArc.
This is in preparation for virtualizing this on SkCanvas/SkDevice.
Tests the following variations:
aa and non-aa
stroke/hairline/fill
cap types
using center point and not
BUG=skia:5227
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002
Committed: https://skia.googlesource.com/skia/+/71c5eee9d55af9b93696b8825561f986cb3b7b9b
Patch Set 1 #Patch Set 2 : cleanup #Patch Set 3 : tiny #Patch Set 4 : more #Patch Set 5 : more #Patch Set 6 : fix naming #
Total comments: 2
Patch Set 7 : Address comment #Patch Set 8 : fix windows compiler warnings #Patch Set 9 : rm line accidentally leftover from previous patch #
Total comments: 2
Messages
Total messages: 23 (12 generated)
Description was changed from ========== Add GMs for testing drawArc. This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 ========== to ========== Add GMs for testing drawArc. This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002 ==========
bsalomon@google.com changed reviewers: + robertphillips@google.com
lgtm https://codereview.chromium.org/2264593002/diff/100001/gm/circulararcs.cpp File gm/circulararcs.cpp (right): https://codereview.chromium.org/2264593002/diff/100001/gm/circulararcs.cpp#ne... gm/circulararcs.cpp:25: p0.setColor(SK_ColorRED); use aa here ?
https://codereview.chromium.org/2264593002/diff/100001/gm/circulararcs.cpp File gm/circulararcs.cpp (right): https://codereview.chromium.org/2264593002/diff/100001/gm/circulararcs.cpp#ne... gm/circulararcs.cpp:25: p0.setColor(SK_ColorRED); On 2016/08/19 15:57:24, robertphillips wrote: > use aa here ? Done.
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2264593002/#ps120001 (title: "Address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2264593002/#ps140001 (title: "fix windows compiler warnings")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by bsalomon@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from robertphillips@google.com Link to the patchset: https://codereview.chromium.org/2264593002/#ps160001 (title: "rm line accidentally leftover from previous patch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add GMs for testing drawArc. This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002 ========== to ========== Add GMs for testing drawArc. This is in preparation for virtualizing this on SkCanvas/SkDevice. Tests the following variations: aa and non-aa stroke/hairline/fill cap types using center point and not BUG=skia:5227 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2264593002 Committed: https://skia.googlesource.com/skia/+/71c5eee9d55af9b93696b8825561f986cb3b7b9b ==========
Message was sent while issue was closed.
Committed patchset #9 (id:160001) as https://skia.googlesource.com/skia/+/71c5eee9d55af9b93696b8825561f986cb3b7b9b
Message was sent while issue was closed.
egdaniel@google.com changed reviewers: + egdaniel@google.com
Message was sent while issue was closed.
https://codereview.chromium.org/2264593002/diff/160001/gm/circulararcs.cpp File gm/circulararcs.cpp (right): https://codereview.chromium.org/2264593002/diff/160001/gm/circulararcs.cpp#ne... gm/circulararcs.cpp:67: DEF_ARC_GM(circular_arcs_fill) { the "circular_arcs_circular_arcs_fill" gm? somehow i feel like this name could be shortened.
Message was sent while issue was closed.
https://codereview.chromium.org/2264593002/diff/160001/gm/circulararcs.cpp File gm/circulararcs.cpp (right): https://codereview.chromium.org/2264593002/diff/160001/gm/circulararcs.cpp#ne... gm/circulararcs.cpp:67: DEF_ARC_GM(circular_arcs_fill) { On 2016/08/19 18:35:18, egdaniel wrote: > the "circular_arcs_circular_arcs_fill" gm? somehow i feel like this name could > be shortened. shoot, should be just fill here. |
