chrome/browser/ui/website_settings/permission_menu_model.cc - Issue 2264583003: [HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_menu_model.cc

Issue 2264583003: [HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove content_settings namespace Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/plugins/plugins_field_trial.cc ('K') | « chrome/browser/plugins/plugins_field_trial.cc ('k') | chrome/browser/ui/website_settings/website_settings_ui.cc » ('j') | chrome/browser/ui/website_settings/website_settings_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_menu_model.cc

diff --git a/chrome/browser/ui/website_settings/permission_menu_model.cc b/chrome/browser/ui/website_settings/permission_menu_model.cc

index 6b9c781d596ff576b2ce078600303163ad81b06a..0c715eec161b9de7ea27697b7df8c6b2ac00229f 100644

--- a/chrome/browser/ui/website_settings/permission_menu_model.cc

+++ b/chrome/browser/ui/website_settings/permission_menu_model.cc

@@ -4,8 +4,8 @@

#include "chrome/browser/ui/website_settings/permission_menu_model.h"

+#include "chrome/browser/plugins/plugins_field_trial.h"

#include "chrome/grit/generated_resources.h"

-#include "components/content_settings/core/browser/plugins_field_trial.h"

#include "content/public/common/origin_util.h"

#include "ui/base/l10n/l10n_util.h"

@@ -21,7 +21,7 @@ PermissionMenuModel::PermissionMenuModel(

#if defined(ENABLE_PLUGINS)

effective_default_setting =

- content_settings::PluginsFieldTrial::EffectiveContentSetting(

+ PluginsFieldTrial::EffectiveContentSetting(

permission_.type, permission_.default_setting);

#endif // defined(ENABLE_PLUGINS)

@@ -108,7 +108,7 @@ bool PermissionMenuModel::IsCommandIdChecked(int command_id) const {

ContentSetting setting = permission_.setting;

#if defined(ENABLE_PLUGINS)

- setting = content_settings::PluginsFieldTrial::EffectiveContentSetting(

+ setting = PluginsFieldTrial::EffectiveContentSetting(

permission_.type, permission_.setting);

#endif // defined(ENABLE_PLUGINS)