[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
Committed: https://crrev.com/a1b97045fc29fd8e045cd2b9bbdbbe1d1104d6dc
Cr-Commit-Position: refs/heads/master@{#414634}

[trizzofo, 2016-08-20 01:30:54]

Description was changed from

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enable, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
==========

to

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
==========

[trizzofo, 2016-08-20 01:54:57]

trizzofo@google.com changed reviewers:
+ tommycli@chromium.org

[trizzofo, 2016-08-20 01:54:58]

tommycli, ptal

[tommycli, 2016-08-22 17:35:32]

lgtm, thanks!

[trizzofo, 2016-08-22 17:53:02]

trizzofo@google.com changed reviewers:
+ bauerb@chromium.org, thestig@chromium.org

[trizzofo, 2016-08-22 17:53:03]

Lei Zhang, ptal at chrome/browser files.
bauerb, ptal at components/content_settings.
Thanks!

[Lei Zhang, 2016-08-22 17:57:55]

lgtm

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/plugins_field_trial.cc (right):

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/plugins_field_trial.cc:14: if (type !=
CONTENT_SETTINGS_TYPE_PLUGINS)
if (type != CONTENT_SETTINGS_TYPE_PLUGINS ||
    setting != ContentSetting::CONTENT_SETTING_ASK) {
  return settings;
}

return base::FeatureList::IsEnabled(...);

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings_ui.cc (right):

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings_ui.cc:229:
PluginsFieldTrial::EffectiveContentSetting(
Fits on previous line? Just git cl format?

[trizzofo, 2016-08-22 18:09:36]

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/plugins/...
File chrome/browser/plugins/plugins_field_trial.cc (right):

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/plugins/...
chrome/browser/plugins/plugins_field_trial.cc:14: if (type !=
CONTENT_SETTINGS_TYPE_PLUGINS)
On 2016/08/22 17:57:54, Lei Zhang wrote:
> if (type != CONTENT_SETTINGS_TYPE_PLUGINS ||
>     setting != ContentSetting::CONTENT_SETTING_ASK) {
>   return settings;
> }
> 
> return base::FeatureList::IsEnabled(...);

Done.

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/ui/websi...
File chrome/browser/ui/website_settings/website_settings_ui.cc (right):

https://codereview.chromium.org/2264583003/diff/20001/chrome/browser/ui/websi...
chrome/browser/ui/website_settings/website_settings_ui.cc:229:
PluginsFieldTrial::EffectiveContentSetting(
On 2016/08/22 17:57:54, Lei Zhang wrote:
> Fits on previous line? Just git cl format?

Done.

[trizzofo, 2016-08-22 18:12:24]

stevenjb, ptal at chrome/browser/ui files.
Thanks!

[trizzofo, 2016-08-22 18:12:59]

trizzofo@google.com changed reviewers:
+ stevenjb@chromium.org

[trizzofo, 2016-08-22 18:13:57]

stevenjb, ptal at chrome/browser/ui files.
Thanks!

[stevenjb, 2016-08-22 18:22:18]

On 2016/08/22 18:13:57, trizzofo wrote:
> stevenjb, ptal at chrome/browser/ui files.
> Thanks!

I am not a c/b/ui owner and don't know anything about these changes. I would
look at c/b/ui/website_settings/OWENRS.

[stevenjb, 2016-08-22 18:22:27]

stevenjb@chromium.org changed reviewers:
- stevenjb@chromium.org

[tommycli, 2016-08-22 18:24:43]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[trizzofo, 2016-08-22 18:32:14]

On 2016/08/22 18:22:18, stevenjb wrote:
> On 2016/08/22 18:13:57, trizzofo wrote:
> > stevenjb, ptal at chrome/browser/ui files.
> > Thanks!
> 
> I am not a c/b/ui owner and don't know anything about these changes. I would
> look at c/b/ui/website_settings/OWENRS.

Oh, sorry about that. Lei Zhang is an owner for
chrome/browser/ui/website_settings. 
We just need your review for
chrome/browser/ui/webui/options/content_settings_handler.cc.
Thanks!

[commit-bot: I haz the power, 2016-08-22 18:33:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-22 21:06:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-22 21:06:20]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bernhard Bauer, 2016-08-23 09:20:23]

lgtm

[trizzofo, 2016-08-23 17:18:13]

The CQ bit was checked by trizzofo@google.com

[trizzofo, 2016-08-23 17:18:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2264583003/#ps40001
(title: "Changes per Lei Zhang's comments")

[commit-bot: I haz the power, 2016-08-23 17:18:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 17:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 17:26:26]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[trizzofo, 2016-08-23 17:40:04]

trizzofo@google.com changed reviewers:
+ dbeam@chromium.org

[trizzofo, 2016-08-23 17:40:05]

dbeam, ptal at chrome/browser/ui/webui/options/content_settings_handler.cc.
Thanks!

[trizzofo, 2016-08-25 00:45:22]

ping: dbeam, ptal. Thanks!

[Dan Beam, 2016-08-25 19:08:35]

lgtm

[trizzofo, 2016-08-25 19:10:01]

The CQ bit was checked by trizzofo@google.com

[commit-bot: I haz the power, 2016-08-25 19:11:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 19:24:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 19:24:05]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[trizzofo, 2016-08-25 19:53:45]

The CQ bit was checked by trizzofo@google.com

[trizzofo, 2016-08-25 19:53:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, tommycli@chromium.org, dbeam@chromium.org,
bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2264583003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2016-08-25 19:54:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 21:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 21:12:23]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[trizzofo, 2016-08-26 00:25:17]

The CQ bit was checked by trizzofo@google.com

[commit-bot: I haz the power, 2016-08-26 00:26:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-26 02:33:45]

Description was changed from

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
==========

to

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
==========

[commit-bot: I haz the power, 2016-08-26 02:33:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-26 02:36:00]

Description was changed from

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728
==========

to

==========
[HBD] Map ASK to DETECT_IMPORTANT_CONTENT when PreferHtmlOverPlugins is enabled

If PreferHtmlOverPlugins feature is enabled, map the obsolete ASK setting to
DETECT_IMPORTANT_CONTENT.

More info about Html5 by Default here: go/hbd-design-doc

BUG=626728

Committed: https://crrev.com/a1b97045fc29fd8e045cd2b9bbdbbe1d1104d6dc
Cr-Commit-Position: refs/heads/master@{#414634}
==========

[commit-bot: I haz the power, 2016-08-26 02:36:01]

Patchset 4 (id:??) landed as
https://crrev.com/a1b97045fc29fd8e045cd2b9bbdbbe1d1104d6dc
Cr-Commit-Position: refs/heads/master@{#414634}