Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: src/compiler/wasm-compiler.cc

Issue 2264533002: [wasm] Add native x64 implementations for I32x4Splat, I32x4ExtractLane (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@macroize_runtime
Patch Set: Fix test comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/wasm-compiler.cc
diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc
index e92a434d1df4d9700532fbf83df6e5e08ae6f9e6..4b454b6b547828e147208eb90fdbeac7e87fb82b 100644
--- a/src/compiler/wasm-compiler.cc
+++ b/src/compiler/wasm-compiler.cc
@@ -2866,6 +2866,12 @@ void WasmGraphBuilder::SetSourcePosition(Node* node,
source_position_table_->SetSourcePosition(node, pos);
}
+Node* WasmGraphBuilder::DefaultS128Value() {
+ return graph()->NewNode(jsgraph()->machine()->CreateInt32x4(),
titzer 2016/08/23 13:06:40 Can you add a TODO that we should just introduce a
gdeepti 2016/08/23 19:53:34 I have a partical CL that introduces a Simd128Cons
+ Int32Constant(0), Int32Constant(0), Int32Constant(0),
+ Int32Constant(0));
+}
+
Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
const NodeVector& inputs) {
switch (opcode) {
@@ -2873,8 +2879,8 @@ Node* WasmGraphBuilder::SimdOp(wasm::WasmOpcode opcode,
return graph()->NewNode(jsgraph()->machine()->Int32x4ExtractLane(),
inputs[0], inputs[1]);
case wasm::kExprI32x4Splat:
- return graph()->NewNode(jsgraph()->machine()->Int32x4ExtractLane(),
- inputs[0], inputs[0], inputs[0], inputs[0]);
+ return graph()->NewNode(jsgraph()->machine()->CreateInt32x4(), inputs[0],
+ inputs[0], inputs[0], inputs[0]);
default:
return graph()->NewNode(UnsupportedOpcode(opcode), nullptr);
}

Powered by Google App Engine
This is Rietveld 408576698