Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 2264533002: [wasm] Add native x64 implementations for I32x4Splat, I32x4ExtractLane (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@macroize_runtime
Patch Set: cctest Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/x64/code-generator-x64.cc
diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc
index 970f85d8d3dcc40cf63327d64c30ce0b816bb151..7b08d195911bf7f6d6d26a79b60eef6841702b63 100644
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -1746,6 +1746,18 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
__ Xorpd(kScratchDoubleReg, kScratchDoubleReg);
__ Subsd(i.InputDoubleRegister(0), kScratchDoubleReg);
break;
+ case kSSECreateInt32x4: {
bbudge 2016/08/22 19:09:52 Would this be the AVX implementation too? In that
gdeepti 2016/08/22 23:26:11 I was conflicted about calling these kX64 ops beca
+ CpuFeatureScope sse_scope(masm(), SSE4_1);
+ XMMRegister dst = i.OutputSimd128Register();
+ __ movd(dst, i.InputRegister(0));
+ __ shufps(dst, dst, 0x0);
+ break;
+ }
+ case kSSEInt32x4ExtractLane: {
+ CpuFeatureScope sse_scope(masm(), SSE4_1);
+ __ pextrd(i.OutputRegister(), i.InputSimd128Register(0), i.InputInt8(1));
bbudge 2016/08/22 19:09:52 Rather than defining kSSE and kAVX values, I think
gdeepti 2016/08/22 23:26:11 Changed to kX64Int32x4ExtractLane, kX64CreateInt32
+ break;
+ }
case kX64Movsxbl:
ASSEMBLE_MOVX(movsxbl);
__ AssertZeroExtended(i.OutputRegister());

Powered by Google App Engine
This is Rietveld 408576698