android envsetup: Stop exporting ANDROID_SDK_ROOT.

android envsetup: Stop exporting ANDROID_SDK_ROOT.

The only reference to itwasis from an unused slave script
which I deleted in r262454.

BUG=330631
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262480

[Yaron, 2014-04-08 18:33:47]

There are references to ANDROID_SDK_ROOT in native_client, webrtc, libjingle but
I think they're all outside the scope of current chrome build and likely have
their own build instructions around their apps. What about gyp_webview? It
doesn't use envsetup but still holds on this variable. Separate change?

lgtm

[Nico, 2014-04-08 19:21:11]

On 2014/04/08 18:33:47, Yaron wrote:
> There are references to ANDROID_SDK_ROOT in native_client, webrtc, libjingle
but
> I think they're all outside the scope of current chrome build and likely have
> their own build instructions around their apps.

Yes.

> What about gyp_webview? It
> doesn't use envsetup but still holds on this variable. Separate change?

gyp_webview isn't meant to be sourced, it's just executed. So in that script,
ANDROID_SDK_ROOT is only exported for the time the script runs. It's exported so
that it's visible in the embedded python code in that script. It could probably
be passed around in a nicer way, but that's mostly unrelated to envsetup.

> lgtm

Thanks!

[Nico, 2014-04-08 19:21:32]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2014-04-08 19:21:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/226453006/1

[commit-bot: I haz the power, 2014-04-08 19:42:08]

Change committed as 262480

[Andrew Hayden (chromium.org), 2014-04-09 15:31:19]

The cr tool also uses this envvar, and can no longer run ADB commands as a
result. We probably need a better solution for CR, but for now we should revert
this.

[Nico, 2014-04-09 16:51:51]

Can cr use build/android/pylib/constants.py to get this path instead?


On Wed, Apr 9, 2014 at 8:31 AM, <andrewhayden@chromium.org> wrote:

> The cr tool also uses this envvar, and can no longer run ADB commands as a
> result. We probably need a better solution for CR, but for now we should
> revert
> this.
>
> https://codereview.chromium.org/226453006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-09 19:38:41]

Also, is there a bug describing what exactly goes wrong? I looked for
"ANDROID_SDK_ROOT" in cs.chromium.org and nothing in cr seems to use this
as far as I can tell.


On Wed, Apr 9, 2014 at 9:51 AM, Nico Weber <thakis@chromium.org> wrote:

> Can cr use build/android/pylib/constants.py to get this path instead?
>
>
> On Wed, Apr 9, 2014 at 8:31 AM, <andrewhayden@chromium.org> wrote:
>
>> The cr tool also uses this envvar, and can no longer run ADB commands as a
>> result. We probably need a better solution for CR, but for now we should
>> revert
>> this.
>>
>> https://codereview.chromium.org/226453006/
>>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Nico, 2014-04-10 19:25:31]

On Wed, Apr 9, 2014 at 12:38 PM, Nico Weber <thakis@chromium.org> wrote:

> Also, is there a bug describing what exactly goes wrong? I looked for
> "ANDROID_SDK_ROOT" in cs.chromium.org and nothing in cr seems to use this
> as far as I can tell.
>

^ ping. what's the status here?


>
>
> On Wed, Apr 9, 2014 at 9:51 AM, Nico Weber <thakis@chromium.org> wrote:
>
>> Can cr use build/android/pylib/constants.py to get this path instead?
>>
>>
>> On Wed, Apr 9, 2014 at 8:31 AM, <andrewhayden@chromium.org> wrote:
>>
>>> The cr tool also uses this envvar, and can no longer run ADB commands as
>>> a
>>> result. We probably need a better solution for CR, but for now we should
>>> revert
>>> this.
>>>
>>> https://codereview.chromium.org/226453006/
>>>
>>
>>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.