Translate: cleanup on how to pass api key to the script

chrome/browser/resources/translate.js

Index: chrome/browser/resources/translate.js
diff --git a/chrome/browser/resources/translate.js b/chrome/browser/resources/translate.js
index 773189e097da556f74170762808dac4e078efab6..f8cebb32788471b6660ce7b4a660fd6a3449594d 100644
--- a/chrome/browser/resources/translate.js
+++ b/chrome/browser/resources/translate.js
@@ -9,7 +9,11 @@
 
 var cr = {};
 
-cr.googleTranslate = (function(key) {
+/**
+ * An object to provide functions to interact with the Translate library.
+ * @type {object}
+ */
+cr.googleTranslate = (function() {
   /**
    * The Translate Element library's instance.
    * @type {object}
@@ -259,11 +263,14 @@ cr.googleTranslate = (function(key) {
       loadedTime = performance.now();
       try {
         lib = google.translate.TranslateService({
-          'key': key,
+          // translateApiKey is predefined by translate_script.cc.
+          'key': translateApiKey,
           'useSecureConnection': true
         });
+        delete translateApiKey;

[Evan Stade, 2013/08/12 15:24:46]

what is this supposed to do?

[Takashi Toyoshima, 2013/08/13 01:18:37]

"var translateApiKey = '...';\r\n" is injected before the script by the C++
code.
I want to remove the reference of the string once it is used.
This is not needed actually, but just in case so that there is less chance for
attackers to access the key.

       } catch (err) {
         error = true;
+        delete translateApiKey;
         return;
       }
       // The TranslateService is not available immediately as it needs to start
@@ -271,4 +278,4 @@ cr.googleTranslate = (function(key) {
       checkLibReady();
     }
   };
-})/* Calling code '(|key|);' will be appended by TranslateHelper in C++ here. */
+})();