Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 22645014: Merge WebKit r153448 (Optimizes the number of updateTextTrackDisplay calls) (Closed)

Created:
7 years, 4 months ago by vcarbune.chromium
Modified:
7 years, 2 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, nessy
Visibility:
Public.

Description

Merge WebKit r153448 (Optimizes the number of updateTextTrackDisplay calls) Calling updateTextTrackDisplay() will cause the entire DOM subtree containing the active cues to be torn down and rebuilt. Only call into this method when text tracks have actually changed. Add an enum parameter to configureTextTrackDisplay() which allows the caller to specify that method should assume that the list of visible text tracks has changed, forcing a call to updateTextTrackDisplay(). http://trac.webkit.org/changeset/153448 R=acolwell TEST=Existing tests pass. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158530

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updates #

Patch Set 3 : Fix and rebase #

Patch Set 4 : Updated tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M LayoutTests/media/video-controls-captions-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 6 chunks +11 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
vcarbune.chromium
7 years, 4 months ago (2013-08-10 18:32:25 UTC) #1
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/22645014/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/22645014/diff/1/Source/core/html/HTMLMediaElement.cpp#oldcode1040 Source/core/html/HTMLMediaElement.cpp:1040: if (hasMediaControls()) Why is this code dropped? Doesn't this ...
7 years, 4 months ago (2013-08-12 20:19:02 UTC) #2
vcarbune.chromium
https://codereview.chromium.org/22645014/diff/1/Source/core/html/HTMLMediaElement.cpp File Source/core/html/HTMLMediaElement.cpp (left): https://codereview.chromium.org/22645014/diff/1/Source/core/html/HTMLMediaElement.cpp#oldcode1040 Source/core/html/HTMLMediaElement.cpp:1040: if (hasMediaControls()) On 2013/08/12 20:19:02, acolwell wrote: > Why ...
7 years, 4 months ago (2013-08-19 22:20:12 UTC) #3
acolwell GONE FROM CHROMIUM
lgtm
7 years, 4 months ago (2013-08-19 22:37:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vcarbune@chromium.org/22645014/6001
7 years, 4 months ago (2013-08-19 22:48:53 UTC) #5
commit-bot: I haz the power
Retried try job too often on blink_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_presubmit&number=5582
7 years, 4 months ago (2013-08-19 23:02:52 UTC) #6
jochen (gone - plz use gerrit)
lgtm
7 years, 4 months ago (2013-08-20 08:05:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vcarbune@chromium.org/22645014/6001
7 years, 4 months ago (2013-08-20 08:06:23 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 4 months ago (2013-08-20 08:17:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vcarbune@chromium.org/22645014/6001
7 years, 4 months ago (2013-08-20 09:36:47 UTC) #10
commit-bot: I haz the power
Retried try job too often on mac_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_blink_rel&number=2733
7 years, 4 months ago (2013-08-20 20:14:37 UTC) #11
jochen (gone - plz use gerrit)
What should we do about this CL?
7 years, 3 months ago (2013-09-12 09:41:11 UTC) #12
vcarbune.chromium
On 2013/09/12 09:41:11, jochen wrote: > What should we do about this CL? Oups, I ...
7 years, 3 months ago (2013-09-12 10:39:08 UTC) #13
vcarbune.chromium
On 2013/09/12 10:39:08, vcarbune.chromium wrote: > On 2013/09/12 09:41:11, jochen wrote: > > What should ...
7 years, 3 months ago (2013-09-12 10:40:42 UTC) #14
vcarbune.chromium
On 2013/09/12 10:40:42, vcarbune.chromium wrote: > On 2013/09/12 10:39:08, vcarbune.chromium wrote: > > On 2013/09/12 ...
7 years, 2 months ago (2013-09-27 14:58:08 UTC) #15
jochen (gone - plz use gerrit)
still lgtm
7 years, 2 months ago (2013-09-30 09:57:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vcarbune@chromium.org/22645014/43001
7 years, 2 months ago (2013-09-30 10:05:39 UTC) #17
commit-bot: I haz the power
7 years, 2 months ago (2013-09-30 10:56:38 UTC) #18
Message was sent while issue was closed.
Change committed as 158530

Powered by Google App Engine
This is Rietveld 408576698