Issue 22645011: policy: use JSON schema to deserialize entries from Windows registry.

Issue 22645011: policy: use JSON schema to deserialize entries from Windows registry. (Closed)

Created:
7 years, 4 months ago by dconnelly

Modified:
7 years ago

Reviewers:
Joao da Silva

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

policy: use JSON schema to deserialize entries from Windows registry. This is CL 3 of 3 that loads policy on Windows using the schema. This replaces the use of base::Value for schema representations with PolicySchema and loads the Chrome JSON schema from a domain descriptor instead of generating it dynamically at runtime. Depends on https://codereview.chromium.org/22493010/ BUG=270667

Patch Set 1 #

Patch Set 2 : accessors from other patch #

Patch Set 3 : fix chrome schema unit tests #

Total comments: 1

Patch Set 4 : fix 3rd party policy unit tests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+240 lines, -185 lines)			Patch
M	chrome/browser/policy/async_policy_loader.h	View	1 2	4 chunks	+14 lines, -10 lines	0 comments	Download
M	chrome/browser/policy/async_policy_loader.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_provider_test.cc	View	1 2 3	5 chunks	+38 lines, -28 lines	0 comments	Download
M	chrome/browser/policy/policy_domain_descriptor.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_domain_descriptor.cc	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_win.h	View	1 2	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_win.cc	View	1 2	7 chunks	+52 lines, -42 lines	0 comments	Download
M	chrome/browser/policy/policy_loader_win_unittest.cc	View	1 2 3	8 chunks	+81 lines, -41 lines	0 comments	Download
M	chrome/browser/policy/registry_dict_win.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/registry_dict_win.cc	View	1 2	5 chunks	+13 lines, -49 lines	0 comments	Download
M	chrome/browser/policy/registry_dict_win_unittest.cc	View	1 2	1 chunk	+16 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dconnelly

https://codereview.chromium.org/22645011/diff/6001/chrome/browser/policy/policy_loader_win_unittest.cc File chrome/browser/policy/policy_loader_win_unittest.cc (right): https://codereview.chromium.org/22645011/diff/6001/chrome/browser/policy/policy_loader_win_unittest.cc#newcode1115 chrome/browser/policy/policy_loader_win_unittest.cc:1115: // Build a schema for an "object" with a ...

7 years, 3 months ago (2013-09-03 16:26:37 UTC) #1

Expand Messages | Collapse Messages