Issue 22645008: Add WebKitUnitTestSupport::readFromFile and deprecate all PlatformFileHandle related methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22645008: Add WebKitUnitTestSupport::readFromFile and deprecate all PlatformFileHandle related methods (Closed)

Created:
7 years, 4 months ago by kinuko

Modified:
7 years, 4 months ago

Reviewers:
jamesr

CC:
blink-reviews, jamesr, eae+blinkwatch, abarth-chromium, kinuko, dglazkov+blink, jeez

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add WebKitUnitTestSupport::readFromFile and deprecate all PlatformFileHandle related methods - Add WebKitUnitTestSupport::readFromFile - Remove WebFileUtilities::{openFile,closeFile,readFromFile} BUG=267341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155941

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -72 lines)			Patch
M	Source/core/platform/FileSystem.h	View	2 chunks	+0 lines, -18 lines	0 comments	Download
M	Source/core/platform/chromium/FileSystemChromium.cpp	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/platform/image-decoders/gif/GIFImageDecoderTest.cpp	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	Source/core/platform/image-decoders/webp/WEBPImageDecoderTest.cpp	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	Source/web/tests/WebImageTest.cpp	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	public/platform/WebFileUtilities.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	public/platform/WebUnitTestSupport.h	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/22645008/1

7 years, 4 months ago (2013-08-12 15:50:08 UTC) #2

Message was sent while issue was closed.

Change committed as 155941

Expand Messages | Collapse Messages