Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: src/heap/heap.h

Issue 2264493002: [heap] Don't clear black areas when deserializing, they will be marked black later anyway. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index a7f3850044a6f1de34857a66d24e8f585317785e..b9b058c1cdb846a4a9a4158b7286104b4f3373d5 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -450,6 +450,8 @@ enum ArrayStorageAllocationMode {
enum class ClearRecordedSlots { kYes, kNo };
+enum class ClearBlackArea { kYes, kNo };
+
class Heap {
public:
// Declare all the root indices. This defines the root list order.
@@ -673,8 +675,12 @@ class Heap {
// Initialize a filler object to keep the ability to iterate over the heap
// when introducing gaps within pages. If slots could have been recorded in
// the freed area, then pass ClearRecordedSlots::kYes as the mode. Otherwise,
- // pass ClearRecordedSlots::kNo.
- void CreateFillerObjectAt(Address addr, int size, ClearRecordedSlots mode);
+ // pass ClearRecordedSlots::kNo. If the filler was created in a black area
+ // we may want to clear the corresponding mark bits with ClearBlackArea::kYes,
+ // which is the default. ClearBlackArea::kNo does not clear the mark bits.
+ void CreateFillerObjectAt(
+ Address addr, int size, ClearRecordedSlots mode,
+ ClearBlackArea black_area_mode = ClearBlackArea::kYes);
bool CanMoveObjectStart(HeapObject* object);
« no previous file with comments | « no previous file | src/heap/heap.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698