Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 2264433002: Revert of Fast path translate() in SkCanvas and SkLiteDL. (Closed)

Created:
4 years, 4 months ago by mtklein
Modified:
4 years, 4 months ago
Reviewers:
herb_g, mtklein_C, reed1
CC:
msarett, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fast path translate() in SkCanvas and SkLiteDL. (patchset #5 id:80001 of https://codereview.chromium.org/2255283002/ ) Reason for revert: speculative Original issue's description: > Fast path translate() in SkCanvas and SkLiteDL. > > This adds didTranslate() so that SkLiteDL (and other canvas recorders) > can record the translate rather than the full concat. > > It also adds a case to SkMatrix::preTranslate() to fast path > translate x translate -> translate (i.e. +=). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2255283002 > > Committed: https://skia.googlesource.com/skia/+/5fa47f4fd13b3158de4599414c86d17649c2dd1c TBR=herb@google.com,reed@google.com,mtklein@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/954df2fe9f4f66655c99af08b108cb582c402c5d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M include/core/SkCanvas.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 chunk +3 lines, -8 lines 0 comments Download
M src/core/SkLiteDL.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkLiteDL.cpp View 3 chunks +3 lines, -12 lines 0 comments Download
M src/core/SkLiteRecorder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/core/SkLiteRecorder.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Fast path translate() in SkCanvas and SkLiteDL.
4 years, 4 months ago (2016-08-19 00:26:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264433002/1
4 years, 4 months ago (2016-08-19 00:43:55 UTC) #3
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 00:44:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/954df2fe9f4f66655c99af08b108cb582c402c5d

Powered by Google App Engine
This is Rietveld 408576698