Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2264403007: compile empty function to ssa from kernel (Closed)

Created:
4 years, 3 months ago by Harry Terkelsen
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove compiler ref from graph_builder #

Patch Set 3 : also import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 4 chunks +23 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 3 months ago (2016-08-25 22:36:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm. woo hoo!
4 years, 3 months ago (2016-08-25 22:47:44 UTC) #3
Harry Terkelsen
4 years, 3 months ago (2016-08-25 23:08:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
140f5b90db2722bb85add51e7042ff1e29266a3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698