Update ui/views menus to use async

Update ui/views menus to use async

Update the menus used in Combobox, BaseScrollbar, and TextField to use
the ASYNC runtype. Also update the naming of the MenuModel in Combobox.

Upate the menus in the views_examples_exe to use the ASYNC runtype.

TEST=manual testing of views, views_examples_exe, views_unittests
BUG=557136, 557130
Committed: https://crrev.com/30d4b86ba58f9dbab255c1fe45b948137cf11b48
Cr-Commit-Position: refs/heads/master@{#414900}

[jonross, 2016-08-25 21:34:26]

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
ui/views/controls/combobox/combobox.cc:900: width,
gfx::GetStringWidth(menu_model_->GetLabelAt(i), font_list));
incidental from cl format

[jonross, 2016-08-25 21:34:30]

The CQ bit was checked by jonross@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:35:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jonross, 2016-08-25 23:02:19]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2016-08-25 23:02:20]

Hey,

In this change I switch over the menus in other ui/views/ classes.

Could you take a look?

Thanks,
Jon

[commit-bot: I haz the power, 2016-08-25 23:33:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:33:10]

Dry run: This issue passed the CQ dry run.

[sky, 2016-08-26 15:29:03]

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
ui/views/controls/combobox/combobox.cc:840: original_button_state_ =
arrow_button_->state();
Why can't you pass this through the bind on line 851? Assuming you do need it as
a member make sure you initialize this (either in member initializer list, or
header).

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/scrollbar...
File ui/views/controls/scrollbar/base_scroll_bar.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/scrollbar...
ui/views/controls/scrollbar/base_scroll_bar.cc:306:
menu_runner_->RunMenuAt(GetWidget(), NULL, gfx::Rect(p, gfx::Size()),
nullptr

https://codereview.chromium.org/2264403006/diff/1/ui/views/examples/tree_view...
File ui/views/examples/tree_view_example.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/examples/tree_view...
ui/views/examples/tree_view_example.cc:139:
context_menu_runner_->RunMenuAt(source->GetWidget(), NULL,
nullptr

[jonross, 2016-08-26 19:11:57]

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
File ui/views/controls/combobox/combobox.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/combobox/...
ui/views/controls/combobox/combobox.cc:840: original_button_state_ =
arrow_button_->state();
On 2016/08/26 15:29:03, sky wrote:
> Why can't you pass this through the bind on line 851? Assuming you do need it
as
> a member make sure you initialize this (either in member initializer list, or
> header).

uh.... I just didn't think of it at the time... my bad. Done.

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/scrollbar...
File ui/views/controls/scrollbar/base_scroll_bar.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/controls/scrollbar...
ui/views/controls/scrollbar/base_scroll_bar.cc:306:
menu_runner_->RunMenuAt(GetWidget(), NULL, gfx::Rect(p, gfx::Size()),
On 2016/08/26 15:29:03, sky wrote:
> nullptr

Done.

https://codereview.chromium.org/2264403006/diff/1/ui/views/examples/tree_view...
File ui/views/examples/tree_view_example.cc (right):

https://codereview.chromium.org/2264403006/diff/1/ui/views/examples/tree_view...
ui/views/examples/tree_view_example.cc:139:
context_menu_runner_->RunMenuAt(source->GetWidget(), NULL,
On 2016/08/26 15:29:03, sky wrote:
> nullptr

Done.

[sky, 2016-08-26 20:19:36]

LGTM

[jonross, 2016-08-27 02:55:53]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2016-08-27 02:56:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-27 10:47:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-27 10:49:55]

Description was changed from

==========
Update ui/views menus to use async

Update the menus used in Combobox, BaseScrollbar, and TextField to use
the ASYNC runtype. Also update the naming of the MenuModel in Combobox.

Upate the menus in the views_examples_exe to use the ASYNC runtype.

TEST=manual testing of views, views_examples_exe, views_unittests
BUG=557136, 557130
==========

to

==========
Update ui/views menus to use async

Update the menus used in Combobox, BaseScrollbar, and TextField to use
the ASYNC runtype. Also update the naming of the MenuModel in Combobox.

Upate the menus in the views_examples_exe to use the ASYNC runtype.

TEST=manual testing of views, views_examples_exe, views_unittests
BUG=557136, 557130

Committed: https://crrev.com/30d4b86ba58f9dbab255c1fe45b948137cf11b48
Cr-Commit-Position: refs/heads/master@{#414900}
==========

[commit-bot: I haz the power, 2016-08-27 10:49:56]

Patchset 2 (id:??) landed as
https://crrev.com/30d4b86ba58f9dbab255c1fe45b948137cf11b48
Cr-Commit-Position: refs/heads/master@{#414900}