Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2264403004: Blink-compatible serialization of ArrayBuffer. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of ArrayBuffer. Transferral is not included in this CL, nor is SharedArrayBuffer. BUG=chromium:148757 Committed: https://crrev.com/2646749cbc3a004b6241c699caacd6fbf316049f Cr-Commit-Position: refs/heads/master@{#38913}

Patch Set 1 #

Patch Set 2 : DecodeInvalidArrayBuffer #

Patch Set 3 : Merge branch 'master' into vs-array-buffer #

Patch Set 4 : cast to size_t (windows) #

Total comments: 2

Patch Set 5 : Merge branch 'master' into vs-array-buffer #

Patch Set 6 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M src/value-serializer.h View 1 2 4 chunks +4 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 2 3 4 5 6 chunks +41 lines, -0 lines 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 2 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (20 generated)
jbroman
4 years, 3 months ago (2016-08-24 22:11:27 UTC) #16
Jakob Kummerow
lgtm https://codereview.chromium.org/2264403004/diff/60001/src/value-serializer.cc File src/value-serializer.cc (right): https://codereview.chromium.org/2264403004/diff/60001/src/value-serializer.cc#newcode93 src/value-serializer.cc:93: // Array buffer. byteLength:uint32_t, then draw data. nit: ...
4 years, 3 months ago (2016-08-25 08:59:36 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264403004/100001
4 years, 3 months ago (2016-08-25 14:14:58 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-08-25 14:43:03 UTC) #23
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 14:44:07 UTC) #25
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2646749cbc3a004b6241c699caacd6fbf316049f
Cr-Commit-Position: refs/heads/master@{#38913}

Powered by Google App Engine
This is Rietveld 408576698