Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2264353003: s390: [interpreter] Make the binary op with Smi bytecode handlers collect type feedback. (Closed)

Created:
4 years, 4 months ago by JaideepBajwa
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

s390: [interpreter] Make the binary op with Smi bytecode handlers collect type feedback. Port b305c7dfcbc11bf9d6f440cba039d733bade92c3 Original commit message: Drive-by fix: the order of parameters in the BinaryOpWithFeedback TurboFan code stubs now reflects the convention of having the context at the end. R=epertoso@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:5273 LOG=N Committed: https://crrev.com/cf6db3fce5f611178d892b324ef33aca3cf79188 Cr-Commit-Position: refs/heads/master@{#38840}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M src/s390/interface-descriptors-s390.cc View 1 chunk +11 lines, -0 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 4 months ago (2016-08-23 15:54:13 UTC) #1
john.yan
lgtm with one question. https://codereview.chromium.org/2264353003/diff/1/src/s390/interface-descriptors-s390.cc File src/s390/interface-descriptors-s390.cc (right): https://codereview.chromium.org/2264353003/diff/1/src/s390/interface-descriptors-s390.cc#newcode276 src/s390/interface-descriptors-s390.cc:276: Register registers[] = {r3, r2, ...
4 years, 4 months ago (2016-08-23 16:31:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264353003/1
4 years, 4 months ago (2016-08-23 17:41:55 UTC) #4
JaideepBajwa
https://codereview.chromium.org/2264353003/diff/1/src/s390/interface-descriptors-s390.cc File src/s390/interface-descriptors-s390.cc (right): https://codereview.chromium.org/2264353003/diff/1/src/s390/interface-descriptors-s390.cc#newcode276 src/s390/interface-descriptors-s390.cc:276: Register registers[] = {r3, r2, r6, r5}; On 2016/08/23 ...
4 years, 4 months ago (2016-08-23 17:46:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 18:40:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 18:40:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf6db3fce5f611178d892b324ef33aca3cf79188
Cr-Commit-Position: refs/heads/master@{#38840}

Powered by Google App Engine
This is Rietveld 408576698