Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2264323003: Make nacl recipes explicitly set GIT_MODE (Closed)

Created:
4 years, 4 months ago by agable
Modified:
4 years, 4 months ago
Reviewers:
bradnelson, martiniss
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M scripts/slave/recipes/nacl.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl.expected/linux_triggered.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl.expected/linux_triggering.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/nacl/sdk_build.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
agable
4 years, 4 months ago (2016-08-23 22:40:19 UTC) #1
martiniss
lgtm
4 years, 4 months ago (2016-08-23 22:49:28 UTC) #2
bradnelson
lgtm
4 years, 4 months ago (2016-08-23 23:21:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264323003/1
4 years, 4 months ago (2016-08-23 23:21:31 UTC) #5
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 23:29:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/a0da269cb320e4bdf115...

Powered by Google App Engine
This is Rietveld 408576698