Issue 2264313002: Swap size values for bounds in Android prerenders

Issue 2264313002: Swap size values for bounds in Android prerenders (Closed)

Created:
4 years, 4 months ago by Yusuf

Modified:
4 years, 4 months ago

Reviewers:
Maria

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Swap size values for bounds in Android prerenders On https://codereview.chromium.org/2259533003/ the bounds rectangle for Android prerenders were initialized with Android style values which flips the size values and also declares the size wrong if the origin is not 0,0 BUG=628302 Committed: https://crrev.com/bde2d5f7208fc394099df2cc65011cd0c21f5547 Cr-Commit-Position: refs/heads/master@{#413612}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/prerender/external_prerender_handler_android.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

Yusuf

The previous CL was supposed to be a no-op. Looks like instead of that I ...

4 years, 4 months ago (2016-08-22 23:51:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264313002/1

4 years, 4 months ago (2016-08-23 00:04:17 UTC) #5

commit-bot: I haz the power

4 years, 4 months ago (2016-08-23 01:05:28 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bde2d5f7208fc394099df2cc65011cd0c21f5547
Cr-Commit-Position: refs/heads/master@{#413612}