Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2264283007: Fix compiler warnings on "make android_arm" (Closed)

Created:
4 years, 3 months ago by Jakob Kummerow
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, Michael Achenbach
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix compiler warnings on "make android_arm" Committed: https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 Cr-Commit-Position: refs/heads/master@{#38937}

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M gypfiles/standalone.gypi View 1 chunk +3 lines, -0 lines 1 comment Download
M src/compiler/js-operator.h View 1 chunk +2 lines, -2 lines 2 comments Download
M src/compiler/js-operator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/deoptimize-reason.h View 1 chunk +1 line, -1 line 1 comment Download
M src/deoptimize-reason.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +2 lines, -1 line 1 comment Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
PTAL. https://codereview.chromium.org/2264283007/diff/1/gypfiles/standalone.gypi File gypfiles/standalone.gypi (right): https://codereview.chromium.org/2264283007/diff/1/gypfiles/standalone.gypi#newcode382 gypfiles/standalone.gypi:382: 'v8_android_log_stdout%': 1, This fixes: ../src/base/platform/platform-posix.cc:34:10: fatal error: 'android/log.h' ...
4 years, 3 months ago (2016-08-25 11:35:11 UTC) #2
Benedikt Meurer
LGTM.
4 years, 3 months ago (2016-08-25 18:24:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264283007/1
4 years, 3 months ago (2016-08-26 09:28:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-26 09:53:21 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3e809a6129d0097529c885579ac46e4acf4e99f6 Cr-Commit-Position: refs/heads/master@{#38937}
4 years, 3 months ago (2016-08-26 09:54:03 UTC) #8
Michael Hablich
4 years, 3 months ago (2016-08-28 20:34:16 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2286163002/ by hablich@chromium.org.

The reason for reverting is: Speculative revert because of roll blocker
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....

Powered by Google App Engine
This is Rietveld 408576698