Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2264273003: [layoutng] LayoutOpportunities() only needs a bool, not an enum (Closed)

Created:
4 years, 4 months ago by cbiesinger
Modified:
4 years, 4 months ago
Reviewers:
ikilpatrick, eae
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] LayoutOpportunities() only needs a bool, not an enum The "avoid" argument only needs to distinguish between block and inline/BFC, so simplify the argument list. R=ikilpatrick@chromium.org,eae@chromium.org BUG=635619 Committed: https://crrev.com/60ff34ab72dc98e9fb050711faf9013d5b9ef9f1 Cr-Commit-Position: refs/heads/master@{#413607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.h View 4 chunks +8 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
cbiesinger
4 years, 4 months ago (2016-08-22 22:59:50 UTC) #1
ikilpatrick
lgtm
4 years, 4 months ago (2016-08-22 23:42:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2264273003/1
4 years, 4 months ago (2016-08-22 23:44:27 UTC) #7
eae
LGTM
4 years, 4 months ago (2016-08-22 23:44:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 00:36:37 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 00:37:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60ff34ab72dc98e9fb050711faf9013d5b9ef9f1
Cr-Commit-Position: refs/heads/master@{#413607}

Powered by Google App Engine
This is Rietveld 408576698