Command buffers: ensure we only read immediate data once

gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file is auto-generated from
 // gpu/command_buffer/build_gles2_cmd_buffer.py
 // It's formatted by clang-format using chromium coding style:
 //    clang-format -i -style=chromium filename
 // DO NOT EDIT!
 
@@ skipping 1548 matching lines @@
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* buffers =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (buffers == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, buffers) || !GenBuffersHelper(n, buffers)) {
+  auto buffers_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* buffers_safe = buffers_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    buffers_safe[i] = buffers[i];
+  if (!CheckUniqueAndNonNullIds(n, buffers_safe) ||
+      !GenBuffersHelper(n, buffers_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGenerateMipmap(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GenerateMipmap& c =
       *static_cast<const gles2::cmds::GenerateMipmap*>(cmd_data);
@@ skipping 16 matching lines @@
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* framebuffers =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (framebuffers == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, framebuffers) ||
-      !GenFramebuffersHelper(n, framebuffers)) {
+  auto framebuffers_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* framebuffers_safe = framebuffers_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    framebuffers_safe[i] = framebuffers[i];
+  if (!CheckUniqueAndNonNullIds(n, framebuffers_safe) ||
+      !GenFramebuffersHelper(n, framebuffers_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGenRenderbuffersImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GenRenderbuffersImmediate& c =
       *static_cast<const gles2::cmds::GenRenderbuffersImmediate*>(cmd_data);
   (void)c;
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* renderbuffers =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (renderbuffers == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, renderbuffers) ||
-      !GenRenderbuffersHelper(n, renderbuffers)) {
+  auto renderbuffers_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* renderbuffers_safe = renderbuffers_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    renderbuffers_safe[i] = renderbuffers[i];
+  if (!CheckUniqueAndNonNullIds(n, renderbuffers_safe) ||
+      !GenRenderbuffersHelper(n, renderbuffers_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGenSamplersImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GenSamplersImmediate& c =
       *static_cast<const gles2::cmds::GenSamplersImmediate*>(cmd_data);
   (void)c;
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* samplers =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (samplers == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, samplers) ||
-      !GenSamplersHelper(n, samplers)) {
+  auto samplers_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* samplers_safe = samplers_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    samplers_safe[i] = samplers[i];
+  if (!CheckUniqueAndNonNullIds(n, samplers_safe) ||
+      !GenSamplersHelper(n, samplers_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGenTexturesImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::GenTexturesImmediate& c =
       *static_cast<const gles2::cmds::GenTexturesImmediate*>(cmd_data);
   (void)c;
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* textures =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (textures == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, textures) ||
-      !GenTexturesHelper(n, textures)) {
+  auto textures_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* textures_safe = textures_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    textures_safe[i] = textures[i];
+  if (!CheckUniqueAndNonNullIds(n, textures_safe) ||
+      !GenTexturesHelper(n, textures_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGenTransformFeedbacksImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   if (!unsafe_es3_apis_enabled())
     return error::kUnknownCommand;
   const gles2::cmds::GenTransformFeedbacksImmediate& c =
       *static_cast<const gles2::cmds::GenTransformFeedbacksImmediate*>(
           cmd_data);
   (void)c;
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* ids = GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (ids == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, ids) ||
-      !GenTransformFeedbacksHelper(n, ids)) {
+  auto ids_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* ids_safe = ids_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    ids_safe[i] = ids[i];
+  if (!CheckUniqueAndNonNullIds(n, ids_safe) ||
+      !GenTransformFeedbacksHelper(n, ids_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleGetBooleanv(uint32_t immediate_data_size,
                                                  const void* cmd_data) {
   const gles2::cmds::GetBooleanv& c =
       *static_cast<const gles2::cmds::GetBooleanv*>(cmd_data);
   (void)c;
@@ skipping 3048 matching lines @@
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* queries =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (queries == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, queries) ||
-      !GenQueriesEXTHelper(n, queries)) {
+  auto queries_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* queries_safe = queries_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    queries_safe[i] = queries[i];
+  if (!CheckUniqueAndNonNullIds(n, queries_safe) ||
+      !GenQueriesEXTHelper(n, queries_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleDeleteQueriesEXTImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::DeleteQueriesEXTImmediate& c =
       *static_cast<const gles2::cmds::DeleteQueriesEXTImmediate*>(cmd_data);
@@ skipping 101 matching lines @@
   GLsizei n = static_cast<GLsizei>(c.n);
   uint32_t data_size;
   if (!SafeMultiplyUint32(n, sizeof(GLuint), &data_size)) {
     return error::kOutOfBounds;
   }
   GLuint* arrays =
       GetImmediateDataAs<GLuint*>(c, data_size, immediate_data_size);
   if (arrays == NULL) {
     return error::kOutOfBounds;
   }
-  if (!CheckUniqueAndNonNullIds(n, arrays) ||
-      !GenVertexArraysOESHelper(n, arrays)) {
+  auto arrays_copy = base::MakeUnique<GLuint[]>(n);
+  GLuint* arrays_safe = arrays_copy.get();
+  for (GLsizei i = 0; i < n; ++i)
+    arrays_safe[i] = arrays[i];
+  if (!CheckUniqueAndNonNullIds(n, arrays_safe) ||
+      !GenVertexArraysOESHelper(n, arrays_safe)) {
     return error::kInvalidArguments;
   }
   return error::kNoError;
 }
 
 error::Error GLES2DecoderImpl::HandleDeleteVertexArraysOESImmediate(
     uint32_t immediate_data_size,
     const void* cmd_data) {
   const gles2::cmds::DeleteVertexArraysOESImmediate& c =
       *static_cast<const gles2::cmds::DeleteVertexArraysOESImmediate*>(
@@ skipping 746 matching lines @@
         state_.enable_flags.cached_sample_alpha_to_one_ext = enabled;
         return true;
       }
       return false;
     default:
       NOTREACHED();
       return false;
   }
 }
 #endif  // GPU_COMMAND_BUFFER_SERVICE_GLES2_CMD_DECODER_AUTOGEN_H_