[NaCL SDK] Ship sys/mount.h for newlib/pnacl.

[NaCL SDK] Ship sys/mount.h for newlib/pnacl.

The primary motivation for this change was to remove the
unnecessary include of kernel_wrap.h from nacl_io.h.

In doing this is realised that we shouldn't be declaring
the mount(2) function in nacl_io.h but instread relying
on <sys/mount.h> for this.

The doxygen comment that was previously attached to
the mount(2) declaration was merged with nacl_io_init.

R=binji@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216818

[Sam Clegg, 2013-08-09 20:59:40]

from nethack_pepper.cc:16:
/usr/local/google/home/sbc/nacl_sdk/pepper_canary/include/nacl_io/ossocket.h:12:18:
error: poll.h: No such file or directory
In file included from 
I started looking at this after noticing a failure on naclports which showed
that nacl_io.h was requiring poll.h:

/usr/local/google/home/sbc/nacl_sdk/pepper_canary/include/nacl_io/ossocket.h:9,
                 from
/usr/local/google/home/sbc/nacl_sdk/pepper_canary/include/nacl_io/kernel_wrap.h:12,
                 from
/usr/local/google/home/sbc/nacl_sdk/pepper_canary/include/nacl_io/nacl_io.h:11,
                 from nethack_pepper.cc:16:

The solution to this is to add the new include/newlib directory to the naclports
include path, however there
is no reason for nacl_io.h to include any of these system
headers... hence this cleanup.

[binji, 2013-08-09 21:10:39]

lgtm, but make sure that the mount documentation is clearly for mount.

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/include/sys/mount.h (right):

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/include/sys/mount.h:6: #define
LIBRARIES_NACL_IO_INCLUDE_MOUNT_H
bad include guard

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/nacl_io.h (right):

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/nacl_io.h:21: * Once nacl_io is
initialised the mount(2)/umount(2) system calls
we use initialize above, so be consistent. :)

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/nacl_io.h:24: * The parameters to pass
to mount(2) are dependent on the filesystem type
I don't really like combining this documentation here. Maybe keep it separated
like before, but just comment out the "mount" declaration?

[Sam Clegg, 2013-08-09 21:19:02]

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/include/sys/mount.h (right):

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/include/sys/mount.h:6: #define
LIBRARIES_NACL_IO_INCLUDE_MOUNT_H
On 2013/08/09 21:10:39, binji wrote:
> bad include guard

Done.

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
File native_client_sdk/src/libraries/nacl_io/nacl_io.h (right):

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/nacl_io.h:21: * Once nacl_io is
initialised the mount(2)/umount(2) system calls
On 2013/08/09 21:10:39, binji wrote:
> we use initialize above, so be consistent. :)

Removed.

https://codereview.chromium.org/22642016/diff/1/native_client_sdk/src/librari...
native_client_sdk/src/libraries/nacl_io/nacl_io.h:24: * The parameters to pass
to mount(2) are dependent on the filesystem type
On 2013/08/09 21:10:39, binji wrote:
> I don't really like combining this documentation here. Maybe keep it separated
> like before, but just comment out the "mount" declaration?

Done.

[Sam Clegg, 2013-08-10 00:57:58]

Fixed examples.

PTAL.

[Sam Clegg, 2013-08-10 07:27:31]

Committed patchset #4 manually as r216818 (presubmit successful).