Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 22642007: Update the menu offsets for the OSX and Win App Launchers. (Closed)

Created:
7 years, 4 months ago by tapted
Modified:
7 years, 4 months ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Visibility:
Public.

Description

Update the menu offsets for the OSX and Win App Launchers. The new menu button assets do not have a border. This moves the menu popup closer to the meat of the icon. BUG=269210 TEST=Visual - menu location should match the screenshot at http://crbug.com/269210#c4 R=benwells@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=216950

Patch Set 1 #

Patch Set 2 : rebase/no-op #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M ui/app_list/cocoa/apps_search_box_controller.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ui/app_list/views/search_box_view.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Based off the binary changes in the CL with id 22254008.
7 years, 4 months ago (2013-08-08 07:49:48 UTC) #1
benwells
lgtm
7 years, 4 months ago (2013-08-08 08:04:30 UTC) #2
tapted
7 years, 4 months ago (2013-08-12 06:02:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r216950 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698