runtime/vm/object.cc - Issue 22642003: Fix name of libraries without a library declaration to be the empty string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 22642003: Fix name of libraries without a library declaration to be the empty string. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: rebase Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 8b4b9ed31c86ed12f89f2dfa03948147f097db38..9bfb6695089d1aca6709ebfaa64f3489ae1859e1 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -7065,7 +7065,7 @@ RawLibrary* Library::New() {

RawLibrary* Library::NewLibraryHelper(const String& url,

bool import_core_lib) {

const Library& result = Library::Handle(Library::New());

- result.StorePointer(&result.raw_ptr()->name_, url.raw());

+ result.StorePointer(&result.raw_ptr()->name_, Symbols::Empty().raw());

result.StorePointer(&result.raw_ptr()->url_, url.raw());

result.raw_ptr()->private_key_ = Scanner::AllocatePrivateKey(result);

result.raw_ptr()->dictionary_ = Object::empty_array().raw();

« no previous file with comments | « runtime/vm/dart_api_impl_test.cc ('k') | tests/lib/lib.status » ('j') | no next file with comments »