chrome/browser/media/router/presentation_media_sinks_observer.cc - Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/presentation_media_sinks_observer.cc

Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Mark's comments, add unit test for CMWMS Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/router/create_presentation_connection_request.cc ('K') | « chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc ('k') | chrome/browser/media/router/presentation_request.h » ('j') | chrome/browser/media/router/presentation_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/presentation_media_sinks_observer.cc

diff --git a/chrome/browser/media/router/presentation_media_sinks_observer.cc b/chrome/browser/media/router/presentation_media_sinks_observer.cc

index 95965908449e01958bb9d3818f0c9b917839e524..b961c424d6afe950fba7b52d3a0eb1b9d5500760 100644

--- a/chrome/browser/media/router/presentation_media_sinks_observer.cc

+++ b/chrome/browser/media/router/presentation_media_sinks_observer.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/media/router/presentation_media_sinks_observer.h"

+#include <vector>

mark a. foltz 2016/09/02 23:00:37 Put in .h

takumif 2016/09/06 21:53:20 Done.

#include "chrome/browser/media/router/media_router.h"

#include "chrome/browser/media/router/media_source.h"

#include "content/public/browser/presentation_screen_availability_listener.h"

@@ -20,7 +22,6 @@ PresentationMediaSinksObserver::PresentationMediaSinksObserver(

previous_availablity_(UNKNOWN) {

DCHECK(router);

DCHECK(listener_);

- DCHECK(!source.Empty());

}

PresentationMediaSinksObserver::~PresentationMediaSinksObserver() {