Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: chrome/browser/media/android/router/media_router_dialog_controller_android.cc

Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Modify MediaRouterDialogControllerAndroid, format Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/router/create_presentation_connection_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/android/router/media_router_dialog_controller_android.cc
diff --git a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
index 298a2ef3f29a2ffb14295a6209e5b8c189bc807a..e57806ec9d70a14945d85c1c97530def446517dc 100644
--- a/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
+++ b/chrome/browser/media/android/router/media_router_dialog_controller_android.cc
@@ -46,7 +46,10 @@ void MediaRouterDialogControllerAndroid::OnSinkSelected(
create_connection_request = TakeCreateConnectionRequest();
const PresentationRequest& presentation_request =
create_connection_request->presentation_request();
- const MediaSource::Id source_id = presentation_request.GetMediaSource().id();
+
+ // TODO(crbug.com/627655): Support multiple URLs.
+ const MediaSource::Id source_id =
+ presentation_request.GetMediaSources()[0].id();
const GURL origin = presentation_request.frame_url().GetOrigin();
std::vector<MediaRouteResponseCallback> route_response_callbacks;
@@ -113,8 +116,11 @@ MediaRouterDialogControllerAndroid::~MediaRouterDialogControllerAndroid() {
void MediaRouterDialogControllerAndroid::CreateMediaRouterDialog() {
JNIEnv* env = base::android::AttachCurrentThread();
- const MediaSource::Id source_id =
- create_connection_request()->presentation_request().GetMediaSource().id();
+ // TODO(crbug.com/627655): Support multiple URLs.
+ const MediaSource::Id source_id = create_connection_request()
+ ->presentation_request()
+ .GetMediaSources()[0]
+ .id();
ScopedJavaLocalRef<jstring> jsource_urn =
base::android::ConvertUTF8ToJavaString(env, source_id);
« no previous file with comments | « no previous file | chrome/browser/media/router/create_presentation_connection_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698