chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc - Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

Issue 2264153002: [Presentation API] Add support for multiple URLs in PresentationRequest on Media Router UI side (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Mark's comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/router/media_source.cc ('k') | chrome/browser/media/router/presentation_media_sinks_observer.h » ('j') | chrome/browser/media/router/presentation_request.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

diff --git a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

index b82ed0996fcc8624f13716655cf7f02c0555364e..4c23da898c52a9b7272f50f08368e5ce6d551628 100644

--- a/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

+++ b/chrome/browser/media/router/mojo/media_router_type_converters_unittest.cc

@@ -91,8 +91,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRoute) {

EXPECT_TRUE(expected_media_route.Equals(media_route));

EXPECT_EQ(expected_media_route.media_sink_id(), media_route.media_sink_id());

EXPECT_EQ(expected_media_route.description(), media_route.description());

- EXPECT_TRUE(

- expected_media_route.media_source().Equals(media_route.media_source()));

+ EXPECT_EQ(expected_media_route.media_source(), media_route.media_source());

EXPECT_EQ(expected_media_route.media_source().id(),

media_route.media_source().id());

EXPECT_EQ(expected_media_route.is_local(), media_route.is_local());

@@ -103,7 +102,7 @@ TEST(MediaRouterTypeConvertersTest, ConvertMediaRoute) {

}

TEST(MediaRouterTypeConvertersTest, ConvertMediaRouteWithoutOptionalFields) {

- MediaRoute expected_media_route("routeId1", MediaSource(), "sinkId",

+ MediaRoute expected_media_route("routeId1", MediaSource("sourceId"), "sinkId",

"Description", false, "", false);

mojom::MediaRoutePtr mojo_route(mojom::MediaRoute::New());

// MediaRoute::media_source is omitted.