Issue 226413009: Fixes for leveldb env_chromium unittests while building in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 226413009: Fixes for leveldb env_chromium unittests while building in GN. (Closed)

Created:
6 years, 8 months ago by tfarina

Modified:
6 years, 8 months ago

Reviewers:
brettw, dgrogan

CC:
chromium-reviews, Dirk Pranke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes for leveldb env_chromium unittests while building in GN. This fixes two compilation errors found while building with gcc 4.8.2: 1- unused variable 'orig_bak_files' [-Werror=unused-variable] 2- comparison between signed and unsigned integer expressions [-Werror=sign-compare] BUG=361857 TEST=ninja -C out/Debug_gn TBR=brettw@chromium.org,dgrogan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262919

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	third_party/leveldatabase/env_chromium_unittest.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/226413009/1

6 years, 8 months ago (2014-04-09 23:48:33 UTC) #3

Message was sent while issue was closed.

Change committed as 262919